Multitenant feature - #71
Conversation
61d9f4c to
c7e2f78
Compare
…dded event_type_uuid to tables that should use this, added can_checkin column to ticket_type table
| op.create_foreign_key(op.f('fk_position_event_type_uuid_event_type'), 'position', 'event_type', ['event_type_uuid'], ['uuid']) | ||
| op.add_column('seatmap', sa.Column('event_type_uuid', sa.UUID(), nullable=True)) | ||
| op.create_foreign_key(op.f('fk_seatmap_event_type_uuid_event_type'), 'seatmap', 'event_type', ['event_type_uuid'], ['uuid']) | ||
| op.add_column('seatmap_background', sa.Column('event_type_uuid', sa.UUID(), nullable=True)) |
There was a problem hiding this comment.
why is nullable true? are we planning to support shared seatmap backgrounds?
There was a problem hiding this comment.
I don't think so, but as everything else in this revision, we need to start with setting nullable to True, and insert an initial event brand uuid before we can set it to false?
| class EventType(Base): | ||
| __tablename__ = "event_type" | ||
|
|
||
| uuid = Column(UUID(as_uuid=True), primary_key=True, default=uuid.uuid4, unique=True, nullable=False) |
There was a problem hiding this comment.
I think we agreed to use a string instead of uuid here, since people will need to know/remember it when configuring clients?
There was a problem hiding this comment.
so like a slug instead of uuid? (which is a string which we enforce to be lowercase letters and -_ or something?
HenrikEngen
left a comment
HenrikEngen
left a comment
There was a problem hiding this comment.
That was alot of code, but looks good to me I think
| (Allow, ADMIN(), 'list'), | ||
|
|
||
| (Allow, Authenticated, 'self'), | ||
| (Allow, Authenticated, 'create'), |
There was a problem hiding this comment.
Skal ikke authenticated users få lov til å opprette søknader?
Nvm, ser de kan opprette søknader i en annen del av koden...
| (Allow, Everyone, 'current::get'), | ||
| (Allow, Everyone, 'get'), | ||
| (Allow, ADMIN, 'create'), | ||
| (Allow, Everyone, 'list'), |
There was a problem hiding this comment.
Skal everyone kunne se alle eventer?
There was a problem hiding this comment.
ja, har vel alltid vært sånn?
| (Allow, ADMIN, 'applications_get'), | ||
| (Allow, ADMIN(), 'event_update'), | ||
|
|
||
| (Allow, CHIEF(self.eventInstance.event_brand_uuid), 'applications_get'), |
There was a problem hiding this comment.
Duplikat av linje 66?
| (Allow, ADMIN(), 'event_update'), | ||
|
|
||
| (Allow, CHIEF(self.eventInstance.event_brand_uuid), 'applications_get'), | ||
| (Allow, ADMIN(), 'applications_get'), |
There was a problem hiding this comment.
Duplikat av linje 67?
| (Allow, ADMIN(), 'applications_get'), | ||
|
|
||
| (Allow, ADMIN(), 'event_edit'), | ||
| (Allow, BRAND_ADMIN(self.eventInstance.event_brand_uuid), 'event_edit'), |
There was a problem hiding this comment.
Forskjell mellom event_update og event_edit?
|
@HenrikEngen ready to merge? |
2 participants
No description provided.