ext/gd/tests: fixup gh16559.phpt and gh17349.phpt with external gd#21987
Open
orlitzky wants to merge 2 commits intophp:PHP-8.3from
Open
ext/gd/tests: fixup gh16559.phpt and gh17349.phpt with external gd#21987orlitzky wants to merge 2 commits intophp:PHP-8.3from
orlitzky wants to merge 2 commits intophp:PHP-8.3from
Conversation
This is a test for a bugfix in the bundled libgd.
Member
|
Hi. two things :
|
This test loads a PNG image, so if an external libgd is being used, it has to support PNG.
orlitzky
changed the title
Contributor
Author
Both of these are new failures in 8.3.31, added in relation to some security issues. If it's worth adding new tests in a security release, then shouldn't it be worthwhile to ensure that they pass? I obviously have a patch for 8.3.x, but if I were slightly less attentive, some of our users would be stuck on 8.3.30 because the upgrade to 8.3.31 fails out-of-the-box. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.