Strip leading/trailing whitespace whitespace from interactive examples#1900
Open
jordikroon wants to merge 1 commit intophp:masterfrom
Open
Strip leading/trailing whitespace whitespace from interactive examples#1900jordikroon wants to merge 1 commit intophp:masterfrom
jordikroon wants to merge 1 commit intophp:masterfrom
Conversation
jordikroon
requested review from
derickr,
saundefined,
sgolemon and
sy-records
as code owners
jordikroon
force-pushed
the
interactive-example/newline
branch
from
e39971d to
501a37a
Compare
jordikroon
changed the title
Contributor
|
📊 Regression report for commit 501a37a is at https://web-php-regression-report-pr-1900.preview.thephp.foundation |
Contributor
|
🚀 Preview for commit 501a37a is available at https://web-php-pr-1900.preview.thephp.foundation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make interactive examples more in line with existing
<screen>output. Resulting in less layout shifting when doingRun code.Live action (Example #3 DateTimeInterface::diff() range):
https://www.php.net/manual/en/datetime.diff.php
It doesn't happen always. It depends on the output.
var_dump(). Leading<br>throw new Exception(). Trailing<br><screen>output we don't usually do this.Before:
After:
