Migrate from Yarn to npm, add unit tests, update dependencies#394
Merged
Conversation
… yarn install in Dockerfile/Makefile - Add ProjectTest covering nginx defaults and elasticsearch enabled state - Add MemcachedTest covering container suffix, enabled state, and external port - Add PostgresTypeValidatorTest for custom message on invalid version - Add functional test for Elasticsearch version in docker-compose - Fix Dockerfile AS keyword casing for consistency - Install yarn@1.22.22 explicitly via npm in Dockerfile and Makefile to avoid relying on system yarn in node images
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate the frontend build tooling from Yarn to npm, replace the Bower-based font-awesome dependency with the direct npm package, add unit tests for several domain classes, and clean up Dockerfile/Makefile.
Changes
Build tooling migration (Yarn → npm)
yarn installwithnpm ci,yarn build:csswithnpm run build:css, copypackage-lock.jsoninstead ofyarn.lock, addWORKDIR /applicationfor correct pathsyarn-installtarget withnpm-install, updatebuild-cssto use npm, updateinstall-dependenciesdependency chain@bower_components/font-awesomedependency, addfont-awesome(npm), switch engines fromyarntonpmDockerfile cleanup
as→AS(uppercase for consistency)/application/prefix and copy font-awesome directly instead of the entire@bower_componentsdirectoryDependency updates
^10.5.0, postcss^8.5.15, postcss-cli^11.0.1, tailwindcss^3.4.19yarn.lockwithpackage-lock.json(npm lockfile v3)New tests