Repository navigation
Implement assertGreaterThan() and assertLessThan() type narrowing - #351
Merged
Merged
Conversation
staabm
marked this pull request as ready for review
November 12, 2026 14:58
Contributor
Author
|
//cc @SanderMuller |
VincentLanglet
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #350
I left out
*OrEqual-variants because PHPUnit checks them as "equal (using its comparator) or greater/less", not as PHP's>=/<=. For ints, floats and numeric strings this makes no difference. For arrays or objects it might narrow slightly differently.