Skip to content

Require array_search()'s haystack argument before reading it #6239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
staabm merged 1 commit into from
Aug 18, 2026
+25 −1
Merged

Require array_search()'s haystack argument before reading it #6239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Analyser/ExprHandler/AssignHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1912,7 +1912,7 @@ private function shouldKeepList(ArrayDimFetch $arrayDimFetch, Scope $scope, Type
$arrayDimFetch->dim instanceof Expr\FuncCall
&& $arrayDimFetch->dim->name instanceof Name
&& $arrayDimFetch->dim->name->toLowerString() === 'array_search'
&& count($arrayDimFetch->dim->getArgs()) >= 1
&& count($arrayDimFetch->dim->getArgs()) >= 2 // the haystack is the second argument
&& $this->isSameVariable($arrayDimFetch->var, $arrayDimFetch->dim->getArgs()[1]->value)
) {
return true;
Expand Down
24 changes: 24 additions & 0 deletions tests/PHPStan/Analyser/nsrt/array-search-offset-argument-count.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
<?php declare(strict_types = 1);

namespace ArraySearchOffsetArgumentCount;

use function PHPStan\Testing\assertType;

function singleArgument(): void
{
$list = [1, 2, 3];
// the haystack is array_search()'s second argument, so a call without one cannot be the
// list-preserving idiom - the call itself is reported as invalid
$list[array_search($list)] = 4;
assertType('array{1|4, 2|4, 3|4, ...<int<min, -1>|int<3, max>|string, 4>}', $list);
}

/**
* @param array{int, list<int>} $args
*/
function unpackedArguments(array $args): void
{
$list = [1, 2, 3];
$list[array_search(...$args)] = 4;
assertType('array{1|4, 2|4, 3|4, ...<int<min, -1>|int<3, max>|string, 4>}', $list);
}
Loading