chore: promote to master - #3101
Merged
Merged
Conversation
The paired-passage tabs stayed white with black ink on every color scheme while the passage body beneath them went dark, because the tab fill, the tab ink and the selection indicator came from MUI's palette (`theme.palette.common.white` / `.black`), which does not follow `--pie-*`. They now read `color.background()` and `color.text()` from `@pie-lib/render-ui`, which resolve to `var(--pie-background, ...)` and `var(--pie-text, ...)` -- the same tokens the passage body already uses, so the tab now carries the colour of the panel it opens. The two `#D9DADA` borders -- the tab outline and the strip's bottom rule -- become `color.borderGray()`. The literal measured roughly 1.2:1 against the dark schemes' surfaces, and the tab outline is the only thing separating an unselected tab from the strip, so it was effectively absent exactly where it did the most work. `--pie-border-gray` is stepped to the 3:1 non-text minimum in every built-in scheme. The strip behind the tabs keeps a host-supplied `--pie-passage-header-background` unchanged on every scheme, which is deliberate: Knowledge Checks' pale green-blue is a client decision and not a scheme's business to override. What changes is the no-host fallback, from a white literal to `color.backgroundDark()`, so the strip follows the theme instead of staying white over a dark body. That covers hosts which never opt in, including the section player when its own card-header token is unset. Both `theme.palette.common.*` lines carried "replace with color.background() once PD-2801 is DONE". PD-2801 is about adding background styling to OT's `color-contrast` class -- the mechanism pie-theme superseded -- and has been Blocked since 2023, so it no longer gates this. Not changed: the selected indicator stays `color.tertiary()` and the MUI indicator bar stays `color.white()`. Both already resolve through tokens every scheme sets, `--pie-white` being remapped to the scheme's own background rather than to white.
…follow-theme fix(passage): let the stimulus tabs follow the theme PIE-818
add support for non-drag mouse navigation PIE-769
add support for non-drag mouse navigation PIE-644
fix: bump libs and shared modules PIE-681, PIE-708
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.