Fix setCurrent and add tests#1109
Merged
Merged
Conversation
Ducasse
reviewed
Jun 19, 2026
| parser := MicParser new. | ||
| secondaryRoot := MicSecondaryRootBlock new. | ||
|
|
||
| parser instVarNamed: 'currentLineNumber' put: 15. |
Contributor
There was a problem hiding this comment.
We should not reflective access to instanceVariable.
Better define a setter and use it.
Ducasse
reviewed
Jun 19, 2026
| the parent of an item list is the list and this is the list that is parent of environment." | ||
| current := aBlock | ||
| current := aBlock. | ||
| aBlock isSecondaryRoot ifTrue: [ currentLineNumber := 1 ] |
Contributor
There was a problem hiding this comment.
You do not need this test.
Remember Do not ask, tell
so here we should simply do
aBlock incrementLineNumberOf: self
And on
RootBlokc >> incrementLineNumber: aParser
aParser currentLineNumber := 1
MicElement >> incrementLineNumber: aParser
^ self
Contributor
|
Ok I will integrated it but this is wrong because the lines after <inputFile...> are wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1108