Skip to content

Fix private comment exposure on public profiles - #369

Merged
Cannonb4ll merged 1 commit into
ploi:mainfrom
bjarn:codex/fix-private-comment-profile
Oct 5, 2026
Merged

Cannonb4ll merged 1 commit into
ploi:mainfrom
bjarn:codex/fix-private-comment-profile

Conversation

@bjarn

@bjarn bjarn commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Exclude private comments from public profile counts and activity.
  • Exclude votes on private comments from public profile activity.
  • Add regression tests for private comments and votes.

Security impact

An authenticated user could read administrator-only private note content through another user profile when the related item was public.

Tests

  • php artisan test --compact tests/Feature/Controllers/PublicUserControllerTest.php

@Cannonb4ll
Cannonb4ll merged commit 17fcb11 into ploi:main Oct 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants