Add aria-pressed to RichText text formatting buttons - #2126
Merged
joelfmrodrigues merged 1 commit intoSep 4, 2026
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Collaborator
|
@jtlivio many thanks! Merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
The Bold, Italic, Underline, and Link buttons pass
checkedto Fluent UI'sIconButtonwithouttoggle.aria-pressedis only rendered whentoggleis set, so screen readers never announce whether a format is active. Since
checkedreflects the active formatting state at the current selection,adding
toggleensures thataria-pressedis exposed correctly for all fourbuttons.
Added regression coverage for Bold, Italic, Underline, and Link, verifying that
each button exposes
aria-pressed="false"in its inactive state.The new tests fail without the fix.
npm run buildpasses with no new warnings.