fix: convert wa-row voiced kana (U+30F8/U+30F9) in toHiraganaCase and toKatakanaCase#62
Open
greymoth-jp wants to merge 1 commit into
Open
Conversation
toHiraganaCase already decomposes ヷ (U+30F7) to わ゛ and ヺ (U+30FA) to を゛, and toKatakanaCase composes them back, but the other two wa-row voiced katakana ヸ (U+30F8) and ヹ (U+30F9) were left out and passed through unconverted. The base letters ヰ/ヱ already map to ゐ/ゑ, so the voiced forms now follow the same pattern: ヸ <=> ゐ゛, ヹ <=> ゑ゛.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toHiraganaCaseandtoKatakanaCasealready handle two of the four wa-row voiced katakana:ヷ(U+30F7) is decomposed toわ゛andヺ(U+30FA) toを゛, andtoKatakanaCasecomposes them back. The other two,ヸ(U+30F8) andヹ(U+30F9), were left out, so they pass through unconverted:The base letters
ヰ/ヱalready convert toゐ/ゑthrough the usual katakana/hiragana offset, so the voiced forms now follow the same pattern asヷ/ヺ:Added a test covering the round-trip for the full wa-row voiced family.
npm testpasses.