Conversation
superseded by 1.2.13 and safer patch
inadvertently removed a patch that prevented a bad override
We need to rework this code entirely later, this check is at best inefficient and at worst redundant. For the time being use more stable mirrors to avoid crashing or stalling the whole toolchain build
Contributor
|
As mentioned on discord, that github |
This reverts commit 278a8e6.
Check if Savannah can be reached with a timer, and if not, use local version to continue the build.
oops...
misspelled workflow_dispatch in initial yml commit, fixed it in the previous commit, but it still thinks it's invalid, so I have to enable push for now to force it to run.
Very messy last few commits... but it works now
Contributor
Author
|
Updated the branch. After fighting with CI, I made a simple helper script that tries Savannah with a timer, and if it fails, fall back to a vendored config. Smoke tested with CI. |
Contributor
|
Cool 👍🏻 is this ready to review ? |
bucanero
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Savannah regularly stalls or even crashes toolchain builds. For instance, this toolchain build on macOS intel reached 62 minutes before it realised that a Savannah link hit a 301 and the file was not downloaded: https://github.com/ps3dev/ps3toolchain/actions/runs/26955482827/job/79531449973
Replaced with most reliable GitHub mirror available.