Repository navigation
Point multi-phase plan reads at the installed plugin - #46
Conversation
The check-plan command and skeleton reads use skills/ under the installed pstack plugin dir from grok plugin list. Drop the check-plan git show origin/main: marker. Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>
caelaxie
left a comment
There was a problem hiding this comment.
changes requested (posted as comment: same account authors and reviews).
most of this matches #44's smallest fix: step 6, the playbook/swarm/opening-a-pr/leaf-skill reads, the swarm ref at :65 and appendix D now point at <plugin>/skills/.... Validate plugin is green, not draft, Closes #44 is right.
two blockers:
multi-phase-plan.md:38over-reaches.<control skill path>is the app repo's control skill (project-local, made by create-verification-skill), not a pstack plugin file, so<plugin>/<control skill path>points at a path that doesn't exist. keep upstreamgit show origin/main:<control skill path>verbatim. that keeps thegit show origin/main:marker in the skeleton, so revert thecheck-plan.mjs:20change too.- no grok harness proof on c8e17ae. this touches plugin content and a script, so post
grok plugin install --trust+grok plugin list/validate on the exact head, plusnode <plugin>/skills/poteto-mode/scripts/check-plan.mjsrun against a plan filled from the new skeleton showing it passes.
note, non-blocking: the verbatim tick prompt still says "Re-read the execution playbook from trunk" while :36 now reads it from the plugin dir. leave it unless you think grok strictly needs it; if you change it, swap only "from trunk".
| - [ ] Read these from the installed pstack plugin dir at program start. Re-read them at every tick. | ||
| - [ ] `<plugin>/skills/poteto-mode/playbooks/<execution playbook>.md` | ||
| - [ ] `<plugin>/skills/swarm/SKILL.md` | ||
| - [ ] `<plugin>/<control skill path>` |
There was a problem hiding this comment.
control skill is the app repo's, not the plugin's. keep upstream verbatim:
| - [ ] `<plugin>/<control skill path>` | |
| - [ ] `git show origin/main:<control skill path>` |
| ]; | ||
| const PROGRAM_H3 = ["Arm the program", "Spawn owners", "PR mechanics", "Verdict and merge", "Boot recipe"]; | ||
| const PROGRAM_MARKERS = ["git show origin/main:", "/loop 1h", "status message"]; | ||
| const PROGRAM_MARKERS = ["/loop 1h", "status message"]; |
There was a problem hiding this comment.
with :38 restored the skeleton still carries git show origin/main:, so keep the upstream marker:
| const PROGRAM_MARKERS = ["/loop 1h", "status message"]; | |
| const PROGRAM_MARKERS = ["git show origin/main:", "/loop 1h", "status message"]; |
Keep upstream git show origin/main:<control skill path> and the check-plan marker. Plugin reads stay on skills/ under the installed pstack dir. Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>
|
Harness at head Installed checkout
Installed Installed
Exit 0. Local A live |
caelaxie
left a comment
There was a problem hiding this comment.
pass (comment review, same account as author).
both blockers fixed on b737c5b. :38 is upstream git show origin/main:<control skill path> verbatim again, and check-plan.mjs is untouched, so the git show origin/main: marker still holds. the rest matches #44's smallest fix: step 6, the plugin-skill reads, :65 and appendix D point at <plugin>/skills/... from grok plugin list. grok 1.0.77 validate + install --trust + list --json on the exact head, plus check-plan.mjs passing on a plan filled from the installed skeleton (issuecomment-6731248469). Validate plugin green, Closes #44, not draft. merging.
Closes #44
Point the multi-phase plan check and skeleton reads at
skills/...under the installed pstack plugin directory fromgrok plugin list. Drop the check-plangit show origin/main:marker.