Skip to content

Point multi-phase plan reads at the installed plugin - #46

Merged
caelaxie merged 2 commits into
mainfrom
cursor/plan-installed-skill-paths-ea3b
Nov 9, 2026
Merged

caelaxie merged 2 commits into
mainfrom
cursor/plan-installed-skill-paths-ea3b

Conversation

@caelaxie

@caelaxie caelaxie commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Closes #44

Point the multi-phase plan check and skeleton reads at skills/... under the installed pstack plugin directory from grok plugin list. Drop the check-plan git show origin/main: marker.

Open in Web Open in Cursor 

The check-plan command and skeleton reads use skills/ under the installed pstack plugin dir from grok plugin list. Drop the check-plan git show origin/main: marker.

Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>

@caelaxie caelaxie left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes requested (posted as comment: same account authors and reviews).

most of this matches #44's smallest fix: step 6, the playbook/swarm/opening-a-pr/leaf-skill reads, the swarm ref at :65 and appendix D now point at <plugin>/skills/.... Validate plugin is green, not draft, Closes #44 is right.

two blockers:

  1. multi-phase-plan.md:38 over-reaches. <control skill path> is the app repo's control skill (project-local, made by create-verification-skill), not a pstack plugin file, so <plugin>/<control skill path> points at a path that doesn't exist. keep upstream git show origin/main:<control skill path> verbatim. that keeps the git show origin/main: marker in the skeleton, so revert the check-plan.mjs:20 change too.
  2. no grok harness proof on c8e17ae. this touches plugin content and a script, so post grok plugin install --trust + grok plugin list/validate on the exact head, plus node <plugin>/skills/poteto-mode/scripts/check-plan.mjs run against a plan filled from the new skeleton showing it passes.

note, non-blocking: the verbatim tick prompt still says "Re-read the execution playbook from trunk" while :36 now reads it from the plugin dir. leave it unless you think grok strictly needs it; if you change it, swap only "from trunk".

- [ ] Read these from the installed pstack plugin dir at program start. Re-read them at every tick.
- [ ] `<plugin>/skills/poteto-mode/playbooks/<execution playbook>.md`
- [ ] `<plugin>/skills/swarm/SKILL.md`
- [ ] `<plugin>/<control skill path>`

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

control skill is the app repo's, not the plugin's. keep upstream verbatim:

Suggested change
- [ ] `<plugin>/<control skill path>`
- [ ] `git show origin/main:<control skill path>`

];
const PROGRAM_H3 = ["Arm the program", "Spawn owners", "PR mechanics", "Verdict and merge", "Boot recipe"];
const PROGRAM_MARKERS = ["git show origin/main:", "/loop 1h", "status message"];
const PROGRAM_MARKERS = ["/loop 1h", "status message"];

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with :38 restored the skeleton still carries git show origin/main:, so keep the upstream marker:

Suggested change
const PROGRAM_MARKERS = ["/loop 1h", "status message"];
const PROGRAM_MARKERS = ["git show origin/main:", "/loop 1h", "status message"];

Keep upstream git show origin/main:<control skill path> and the check-plan marker. Plugin reads stay on skills/ under the installed pstack dir.

Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>
@cursor

cursor Bot commented Nov 9, 2026

Copy link
Copy Markdown

Harness at head b737c5ba8eca5683f8cd7646aa05ac8ad9193c57, grok 1.0.77 (50ca579fa996). Isolated HOME. No earlier proof comment on this PR.

$ grok --version
grok 1.0.77 (50ca579fa996)

$ grok plugin validate .
Plugin manifest is valid.
  name: pstack
  version: 0.15.36
  components: 1 skill dir(s), 0 command dir(s), 1 agent dir(s)

$ grok plugin install https://github.com/pstack-ports/grok-pstack@cursor/plan-installed-skill-paths-ea3b --trust
Installed 1 plugin(s) from https://github.com/pstack-ports/grok-pstack@cursor/plan-installed-skill-paths-ea3b: pstack

$ grok plugin list --json
[
  {
    "status": "installed",
    "name": "pstack",
    "repo_key": "grok-pstack-619a4a2c",
    "version": "0.15.36",
    "path": "/tmp/tmp.pKl6IFGQuu/.grok/installed-plugins/grok-pstack-619a4a2c",
    "source": "https://github.com/pstack-ports/grok-pstack",
    "marketplace": null
  }
]

Installed checkout HEAD is b737c5ba8eca5683f8cd7646aa05ac8ad9193c57 (cursor/plan-installed-skill-paths-ea3b). grok plugin validate on that path: Plugin manifest is valid.

grok inspect --json: plugin pstack is enabled (provides.skills 61, provides.agents 1).

Installed skills/poteto-mode/playbooks/multi-phase-plan.md:

10: 6. Run `node <plugin>/skills/poteto-mode/scripts/check-plan.mjs <plan.md>` ... `<plugin>` is the installed path from `grok plugin list` for the copy whose `plugin.json` name is `pstack`.
26: The program runs `<plugin>/skills/poteto-mode/playbooks/<execution playbook>.md`.
36:   - [ ] `<plugin>/skills/poteto-mode/playbooks/<execution playbook>.md`
37:   - [ ] `<plugin>/skills/swarm/SKILL.md`
38:   - [ ] `git show origin/main:<control skill path>`
39:   - [ ] `<plugin>/skills/poteto-mode/playbooks/opening-a-pr.md`
40:   - [ ] `<plugin>/skills/<each other leaf skill the program uses>`
65: Run each full swarm per `<plugin>/skills/swarm/SKILL.md`.
152: Which PRs get `<plugin>/skills/how/SKILL.md` and `<plugin>/skills/interrogate/SKILL.md`. The trail per `<plugin>/skills/show-me-your-work/SKILL.md`.

Installed skills/poteto-mode/scripts/check-plan.mjs:20:

const PROGRAM_MARKERS = ["git show origin/main:", "/loop 1h", "status message"];

node <installed>/skills/poteto-mode/scripts/check-plan.mjs on a plan filled from that installed skeleton (placeholders replaced, including git show origin/main:skills/verify-app/SKILL.md and <plugin>/skills/... paths):

Update the greeting (PR 1)  boxes=27  files=3 build=1 you-see=1 verify-unit=1 verify-live=10 verify-perf=4 review-gate=3 merge=4
1 PR sections, 0 problems

Exit 0.

Local bun run test in skills/poteto-mode/scripts: 61 pass, 0 fail.

A live grok -p turn is auth-blocked (Not signed in).

@caelaxie caelaxie left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass (comment review, same account as author).

both blockers fixed on b737c5b. :38 is upstream git show origin/main:<control skill path> verbatim again, and check-plan.mjs is untouched, so the git show origin/main: marker still holds. the rest matches #44's smallest fix: step 6, the plugin-skill reads, :65 and appendix D point at <plugin>/skills/... from grok plugin list. grok 1.0.77 validate + install --trust + list --json on the exact head, plus check-plan.mjs passing on a plan filled from the installed skeleton (issuecomment-6731248469). Validate plugin green, Closes #44, not draft. merging.

@caelaxie
caelaxie merged commit f4bc9c2 into main Nov 9, 2026
1 check passed
@caelaxie
caelaxie deleted the cursor/plan-installed-skill-paths-ea3b branch November 9, 2026 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

multi-phase-plan still calls pstack/skills/... paths that don't exist in a grok install

2 participants