Repository navigation
Conversation
The create endpoints under /catalogs/{id} looked the catalog up before
their transaction and catalog_id has no foreign key, so a concurrent
DELETE could count no resources, delete the catalog and let the insert
follow, leaving software, publishers or logs tied to a catalog that no
longer exists. Both sides now lock the catalog row first, so one of
them waits for the other and sees its outcome.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The create endpoints under /catalogs/{id} looked the catalog up before
their transaction and catalog_id has no foreign key, so a concurrent
DELETE could count no resources, delete the catalog and let the insert
follow, leaving software, publishers or logs tied to a catalog that no
longer exists. Both sides now lock the catalog row first, so one of
them waits for the other and sees its outcome.