Make concurrent package signing race-safe - #1483
Open
daviddavis wants to merge 1 commit into
Open
Conversation
daviddavis
force-pushed
the
signing-integritryerror
branch
from
July 22, 2026 13:34
76c1e6b to
be24d96
Compare
_sign_package used a non-atomic check-then-create for DebPackageSigningResult, so concurrently signing the same original artifact with the same fingerprint could violate the (sha256, package_signing_fingerprint) unique constraint and abort signed_add_and_remove. Wrap the writes in a transaction and reuse the existing result on IntegrityError. fixes pulp#1482 Assisted-by: Claude Opus 4.8 <noreply@anthropic.com>
daviddavis
force-pushed
the
signing-integritryerror
branch
from
July 24, 2026 18:34
be24d96 to
1f3c969
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_sign_package used a non-atomic check-then-create for DebPackageSigningResult, so concurrently signing the same original artifact with the same fingerprint could violate the (sha256, package_signing_fingerprint) unique constraint and abort signed_add_and_remove. Wrap the writes in a transaction and reuse the existing result on IntegrityError.
fixes #1482
Assisted-by: Claude Opus 4.8 noreply@anthropic.com