(MODULES-11724) Add Puppet 9 support - #126
Open
imaqsood wants to merge 1 commit into
Open
Conversation
imaqsood
force-pushed
the
MODULES-11724
branch
2 times, most recently
from
August 10, 2026 15:21
3fbcedc to
eef1b7a
Compare
Widen the puppet requirement to < 10.0.0 and refresh supported OSes (drop EOL/no-agent platforms; add RedHat 10 and Debian 13 where applicable). Gate the newer lint stack (puppet-lint 5.x) behind the Puppet 9 (8.99.x) stream since puppet-lint 4.x crashes on Ruby 3.4+, resolve Puppet 9 prerelease gems from PUPPET_GEM_SOURCE, and disable strict_indent (its expected indentation differs incompatibly between the 7/8 and 9 lint lanes). Point the Spec workflow at the Puppet 9 gem-source branch (installing libcurl headers for the patron native extension) and exclude ubuntu-20.04 from the Puppet 9 acceptance lane only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
imaqsood
force-pushed
the
MODULES-11724
branch
from
August 10, 2026 15:23
eef1b7a to
e63946d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Puppet 9 support to
puppetlabs-node_encrypt, mirroring the approach used in puppetlabs-motd / inifile / apache (MODULES-11700).metadata.json
puppetrequirement from>= 8.0.0 < 9.0.0to>= 8.0.0 < 10.0.0.Gemfile (variant A — has
gems['bolt'], gem source viagemsource_puppetcore)puppet9_streamflag that detects the Puppet 9 (8.99.x) stream fromPUPPET_GEM_VERSION.voxpupuli-puppet-lint-pluginsto~> 7.0on the Puppet 9 stream (~> 5.0otherwise), since puppet-lint 4.x crashes on Ruby 3.4+.puppet/factergems fromPUPPET_GEM_SOURCE(falling back to puppetcore when empty) using a prerelease-aware range;gems['bolt']left in place.Lint / spec gating
strict_indentin the Rakefile (its expected indentation differs incompatibly between the 7/8 and 9 lint lanes).ci.yml
puppetlabs/cat-github-actions/.github/workflows/module_ci.yml@MODULES-11700-puppet9-gem-source.libcurl4-openssl-dev(patron native extension needs libcurl headers) and inherit secrets.Temporary branch dependencies
puppetlabs_spec_helper→ git branchMODULES-11700-allow-puppet-lint-5(allows puppet-lint 5.x).puppet_litmus→ git branchMODULES-11700-collection-platform-exclude(adds--collection-platform-exclude).cat-github-actions→@MODULES-11700-puppet9-gem-source.All three are TODO-marked to revert to released gems once the upstream support ships.
Local verification
rake lintexit 0; unit specs 28 examples, 0 failures.rake lintexit 0.https://perforce.atlassian.net/browse/MODULES-11724