Only set sqlite WAL on file creation to allow for concurrent runs on Windows#1402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After parallelising the test suite in #1395, we are now often getting these failures for the Windows CI (e.g. this one:
I think this happens because on Windows
PRAGMA journal_mode = WALcallswinTruncateon the wal-index file (the.shm) and concurrent runs that go through this mean that each one sees an inconsistent state.Since according to the docs the WAL mode is persistent across database reopens, we only need to run the pragma once on file creation.