Guard PWD conversion - #313
Merged
Merged
Conversation
Due to axiomatic differences in how output of python functions is to be interpreted. Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Liam Huber <liamhuber@greyhavensolutions.com>
Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Liam Huber <liamhuber@greyhavensolutions.com>
For symmetry with validating the opposite direction Signed-off-by: Liam Huber <liamhuber@greyhavensolutions.com>
Where we actually run the converted recipes. Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Liam Huber <liamhuber@greyhavensolutions.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #313 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 44 44
Lines 3569 3585 +16
=======================================
+ Hits 3567 3583 +16
Misses 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flowrep and PWD's axioms about how to interpret the result of a python function call fundamentally differ, overlapping only when the function output is shunted to a single output port. Here we add new guardrails so converting recipes where we'd bump into this axiomatic difference fail cleanly.
Closes #312