fix: prevent rerun when teardown error matches --rerun-except - #338
Merged
icemac merged 5 commits intoAug 3, 2026
Merged
Conversation
pctablet505
marked this pull request as ready for review
July 17, 2026 12:47
icemac
approved these changes
Aug 3, 2026
icemac
left a comment
icemac
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you for the PR.
icemac
enabled auto-merge (squash)
August 3, 2026 06:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #270
When --rerun-except is used and a teardown failure matches the excluded error, the test was still rerun because only the current report's stage was checked for terminal errors. Now all stages of the current execution are considered, so a terminal teardown error prevents reruns as expected.