Repository navigation
Fix typed deque serialization in the msgspec converter - #819
Merged
Merged
Conversation
Merging this PR will not alter performance1 note
Comparing Footnotes |
Member
|
LGTM. Please add a link to the PR and issue. Would be good to ensure all preconf converters can handle deques but that may be an issue for a different PR. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The msgspec converter treats typed deques as passthrough sequences when their elements need no conversion. Msgspec cannot encode deques, so
dumps()raisesTypeError, including for deque fields inside attrs classes and dataclasses.For example, a
Queuedataclass withpending: deque[int]and valuedeque([1, 2])currently fails to serialize. This change producesb'{"pending":[1,2]}', which loads back into the same queue.Generate the normal iterable hook for deques, and resolve class field annotations before checking passthrough eligibility so postponed dataclass annotations work too. Add regressions for bare and typed deques, empty values, attrs/dataclass fields, dump hooks, and custom element hooks.
Closes #818