Replace gunicorn with waitress#1614
Merged
Merged
Conversation
This commit replaces the `gunicorn` WSGI server with `waitress`. It loses the statsd statistics, but gives us peace of mind. The setup was tested by commenting out the `python manage.py run` command in `docker-compose.yml`. Note that migrations need to be run for the index page to work via `podman compose exec web -- python manage.py migrate`. Rationale ========= Over the last few months, our dependency `gunicorn` has received a large amount of contributions written primarily by the maintainer with close to zero external review. None of these implemented features are anything we need: dirty workers, uWSGI protocol support, control socket, shared memory, .... Nor do I ever recall looking for any of these features in it. The sheer volume of code and the general format of changes also strongly reeks of LLM authorship or assistance. Of course, every maintainer is free to do with their software whatever they wish. But, as with any other dependency, I will evaluate any updates, keeping in mind that any dependency we have here has full access to our database and API. We do not need a WSGI server with regular feature development. We need one that works and is maintained - that is the only requirement. See the linked issue for more discussion. Fixes: #1613 Signed-off-by: Johannes Christ <jc@jchri.st>
✅ Deploy Preview for pydis-static ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
coverage: 100.0%. remained the same — waitress into main |
ChrisLovering
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit replaces the
gunicornWSGI server withwaitress. Itloses the statsd statistics, but gives us peace of mind.
The setup was tested by commenting out the
python manage.py runcommand in
docker-compose.yml. Note that migrations need to be run forthe index page to work via
podman compose exec web -- python manage.py migrate.Rationale
Over the last few months, our dependency
gunicornhas received a large amountof contributions written primarily by the maintainer with close to zero external
review.
None of these implemented features are anything we need: dirty workers,
uWSGI protocol support, control socket, shared memory, .... Nor do I
ever recall looking for any of these features in it.
The sheer volume of code and the general format of changes also strongly reeks
of LLM authorship or assistance.
Of course, every maintainer is free to do with their software whatever they
wish. But, as with any other dependency, I will evaluate any updates, keeping in
mind that any dependency we have here has full access to our database and API.
We do not need a WSGI server with regular feature development. We need one that
works and is maintained - that is the only requirement. See the linked
issue for more discussion.
Fixes: #1613