Host ']' #90

Activity

1. kenballus commented on Feb 7, 2023

   

   kenballus

   on Feb 7, 2023

   ContributorAuthor

   More actions

   Also a problem when host is '['
2. sigmavirus24 commented on Feb 15, 2023

   

   sigmavirus24

   on Feb 15, 2023

   Collaborator

   More actions

   Happy to accept a fix here
3. frenzymadness commented on Apr 18, 2023

   

   frenzymadness

   on Apr 18, 2023

   More actions

   The question here is whether the validation should or should not be implicit when using uri_reference. The truth is that it parses the URI and returns an invalid result by default:

   In [1]: from rfc3986 import uri_reference
   
   In [2]: uri_reference("B://]")
   Out[2]: URIReference(scheme='B', authority=']', path=None, query=None, fragment=None)

   But you can simply check the validity of the result by the is_valid() method:

   In [3]: _.is_valid()
   Out[3]: False

   If you want the validation to happen immediately during parsing, you can use ParseResult:

   In [4]: from rfc3986 import ParseResult
   
   In [5]: ParseResult.from_string("B://]")
   …
   InvalidAuthority: The authority (]) is not valid.

   So, because the lib is already able to say that the URL is invalid, it's more a design decision if the validation should happen by default.
4. sigmavirus24 commented on Apr 18, 2023

   

   sigmavirus24

   on Apr 18, 2023

   Last edited by sigmavirus24

   Collaborator

   More actions

   Pretty sure uri_reference was always intended to be non-validating so that the rest could be API compatible with urllib3 more or less.

   Maybe we need to make that clearer in the docs
5. frenzymadness commented on Apr 18, 2023

   

   frenzymadness

   on Apr 18, 2023

   More actions

   @kenballus could you please clarify which approach did you use?
6. kenballus commented on Apr 19, 2023

   

   kenballus

   on Apr 19, 2023

   ContributorAuthor

   More actions

   My mistake; using ParseResult.from_string fixes this. I should have read the docs more thoroughly.

   Why is it that we have a non-validating parser? Some large projects (httpx) use this parser, and would probably be better off using ParseResult.from_string.