chore: drop defunct pocket, runkeeper, echosign, and exacttarget backends - #1923
Open
aviseth wants to merge 3 commits into
Open
chore: drop defunct pocket, runkeeper, echosign, and exacttarget backends#1923aviseth wants to merge 3 commits into
aviseth wants to merge 3 commits into
Conversation
…ends These backends target services that no longer offer the OAuth endpoints they hardcode: - pocket: Mozilla shut Pocket down entirely in July 2025; the service, apps, and getpocket.com API are gone. - runkeeper: ASICS discontinued the RunKeeper Health Graph API for third-party integrations, breaking the runkeeper.com OAuth flow. - echosign: Adobe rebranded EchoSign to Adobe Sign and migrated off echosign.com; the hardcoded secure.echosign.com endpoints are retired. - exacttarget: ExactTarget became Salesforce Marketing Cloud and its legacy authentication was retired in 2019. Issue python-social-auth#1176
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1923 +/- ##
==========================================
+ Coverage 87.32% 87.92% +0.59%
==========================================
Files 352 347 -5
Lines 13713 13581 -132
Branches 675 668 -7
==========================================
- Hits 11975 11941 -34
+ Misses 1494 1396 -98
Partials 244 244
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Can you please do matching edits in https://github.com/python-social-auth/social-docs/? |
Author
|
Done — python-social-auth/social-docs#484. Only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picking up #1176 (identify and remove outdated backends). These four backends all target services that no longer expose the OAuth endpoints they hardcode, so authentication against them can't succeed anymore:
getpocket.comAPI were removed and data purged. Thegetpocket.com/v3/oauthendpoints are gone. (No test file existed.)runkeeper.com/apps/authorizeOAuth flow this backend depends on. (No test file existed.)echosign.comtoadobesign.com; the hardcodedsecure.echosign.comauthorize/token endpoints are retired. (No test file existed.)Each backend is referenced only in its own module (and, for exacttarget, its own test) —
social_core/backends/__init__.pyis empty and there's no in-repo backend registry or docs to update, so removal is complete. The full test suite passes after the removals.I've followed the pattern of the earlier removals (#1411 itembase, and the nk / rdio / shimmering drops) and left the
### RemovedCHANGELOG bullets for you to batch at release time, as with those — happy to add them here instead if you'd prefer.I kept this to backends I'm confident are definitively dead. A few more are strong candidates but slightly more arguable (e.g.
vend, now Lightspeed X-Series;angel, now Wellfound) — glad to send a follow-up if you'd like those pruned too.