gh-149807 : frozendict_hash : hash (key, value) pairs rather than keys and values separately#149808
Open
lambda-abstraction wants to merge 2 commits into
Open
gh-149807 : frozendict_hash : hash (key, value) pairs rather than keys and values separately#149808lambda-abstraction wants to merge 2 commits into
frozendict_hash : hash (key, value) pairs rather than keys and values separately#149808lambda-abstraction wants to merge 2 commits into
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Author
|
I think making combine_hashes a specialization unroll of tuple xxhash for 2 elements could be good, to avoid creating a tuple and the branching of the loop while using an already trusted algorithm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i used the simple old boost hash_combine rather than directly reusing the tuple xxhash because i think its overkill for the case of combining 2 hashes in a structure where the first elements are different
im sure there is an equally cheap and simple but a better distributed combination function for 2 hashes, but im not sure what it is, so thats open for modification
frozendict_hashdoesnt match the PEP and might have too many collisions #149807