Repository navigation
gh-153668: extend winarm64 compiler workaround to msvc 14.52 - #162262
tonghuaroot wants to merge 1 commit into
Conversation
MSVC 14.52 still triggers the excessive-memory optimizer failure in unicodectype.c. Apply the existing Windows ARM64 workaround to this toolset version.
|
Added the issue link created by the bedevere bot again. @tonghuaroot please do not delete the issue links. They are auto-generated based on the |
| @@ -0,0 +1,2 @@ | |||
| Apply the existing ``unicodectype.c`` optimization workaround to Windows | |||
There was a problem hiding this comment.
| Apply the existing ``unicodectype.c`` optimization workaround to Windows | |
| Disable ``unicodectype.c`` optimization on WinARM64 due to a compiler bug in MSVC 14.50, 14.51 and 14.52. |
The original PR #153669 did use skip-issue, but now that tree compiler versions are affected, I agree it's worth to mention.
I'd also use the Windows category here, even though it is a Build issue as well.
There was a problem hiding this comment.
I would suggest keeping it in Build and clarify that it only affects regular Release builds, not the PGO builds that most users download. So you only hit the issue if you're building it yourself.
Whether NEWS readers make that distinction or not, I've got no idea. But that's the way I've always seen the difference between the two categories.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
msvc 14.52 still triggers the optimizer heap exhaustion reported in gh 153668. this extends the existing windows arm64 workaround to this toolset version.
the windows arm64 release build and the full jit workflow pass with the same runner image.