Skip to content

gh-153668: extend winarm64 compiler workaround to msvc 14.52 - #162262

Open
tonghuaroot wants to merge 1 commit into
python:mainfrom
tonghuaroot:fix-msvc-arm64-1452
Open

tonghuaroot wants to merge 1 commit into
python:mainfrom
tonghuaroot:fix-msvc-arm64-1452

Conversation

@tonghuaroot

@tonghuaroot tonghuaroot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

msvc 14.52 still triggers the optimizer heap exhaustion reported in gh 153668. this extends the existing windows arm64 workaround to this toolset version.

the windows arm64 release build and the full jit workflow pass with the same runner image.

MSVC 14.52 still triggers the excessive-memory optimizer failure in unicodectype.c. Apply the existing Windows ARM64 workaround to this toolset version.
@chris-eibl

Copy link
Copy Markdown
Member

Added the issue link created by the bedevere bot again. @tonghuaroot please do not delete the issue links. They are auto-generated based on the gh- prefix we use on all PR titles, and that's one of the reasons why we use these prefixes.

@chris-eibl
chris-eibl self-requested a review November 20, 2026 19:11
@@ -0,0 +1,2 @@
Apply the existing ``unicodectype.c`` optimization workaround to Windows

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Apply the existing ``unicodectype.c`` optimization workaround to Windows
Disable ``unicodectype.c`` optimization on WinARM64 due to a compiler bug in MSVC 14.50, 14.51 and 14.52.

The original PR #153669 did use skip-issue, but now that tree compiler versions are affected, I agree it's worth to mention.

I'd also use the Windows category here, even though it is a Build issue as well.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest keeping it in Build and clarify that it only affects regular Release builds, not the PGO builds that most users download. So you only hit the issue if you're building it yourself.

Whether NEWS readers make that distinction or not, I've got no idea. But that's the way I've always seen the difference between the two categories.

@bedevere-app

bedevere-app Bot commented Nov 20, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants