Repository navigation
Report NewType used as the first argument of issubclass() - #22505
Closed
zhengdaodeguL wants to merge 1 commit into
Closed
zhengdaodeguL wants to merge 1 commit into
zhengdaodeguL wants to merge 1 commit into
Conversation
issubclass() with a NewType as its first argument fails at runtime (TypeError: issubclass() arg 1 must be a class), but mypy only reported a NewType used as the second argument. Check the first argument the same way, including NewTypes inside a tuple. Fixes python#22504
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22504
issubclass()with a NewType as its first argument fails at runtime (TypeError: issubclass() arg 1 must be a class), but mypy only reported a NewType used as the second argument. Now the first argument is checked too, using the existingflatten()expansion so a NewType inside a tuple is also caught.isinstance()'s first argument is intentionally untouched (it takes an instance value, and a NewType value is its base-class value at runtime).Added
issubclass(T, object)andissubclass((T,), object)expectations totestNewTypeWithIsInstanceAndIsSubclassincheck-newtype.test.