Python 3.15: sort allowlists, more small updates#15714
Conversation
# Conflicts: # stdlib/_interpqueues.pyi # stdlib/ast.pyi # stdlib/base64.pyi # stdlib/collections/__init__.pyi # stdlib/glob.pyi # stdlib/importlib/metadata/__init__.pyi # stdlib/pyexpat/__init__.pyi # stdlib/sys/__init__.pyi # stdlib/threading.pyi # stdlib/types.pyi # stdlib/typing.pyi # stdlib/unicodedata.pyi # stdlib/unittest/_log.pyi # stdlib/unittest/case.pyi # stdlib/wave.pyi # stdlib/zipimport.pyi
This comment has been minimized.
This comment has been minimized.
|
I would like to get the testing infrastructure for 3.15 up before adding 3.15 branches. It also doesn't fill me with confidence that we already have stubtest errors without even testing 3.15. |
|
Here's my suggestion on how to move forward:
|
|
Hi! There's one new addition in 3.15 which I notice is missing from the release notes and the current PR: I guess if the What's New is up to date there shouldn't be a problem for the AI but maybe there are other changes also missing? |
|
wave.open: Yes, I had it look only at the What's New. I think we're liable to miss such changes to only allowed parameter types, because there's no automatic way to check them; I wouldn't be surprised if we similarly missed some changes for earlier versions. Maybe I'll try making an AI look at the whole diff between 3.14 and 3.15 and flag things that were missed. Point taken on getting CI set up first, I'll do that. The stubtest failures seem to be mostly from changes that were made unconditionally that should have been made conditional on version. |
|
My plan now:
|
I'll try to prioritize reviewing. If it's just small, straight-forward changes, I'm fine with larger PRs. It's more about the amount if lines and the complexity than the amount of modules. |
This comment has been minimized.
This comment has been minimized.
# Conflicts: # stdlib/@tests/stubtest_allowlists/darwin-py315.txt # stdlib/@tests/stubtest_allowlists/linux-py315.txt # stdlib/@tests/stubtest_allowlists/py315.txt # stdlib/@tests/stubtest_allowlists/win32-py315.txt # stdlib/_collections_abc.pyi # stdlib/_socket.pyi # stdlib/_ssl.pyi # stdlib/binascii.pyi # stdlib/builtins.pyi # stdlib/calendar.pyi # stdlib/collections/__init__.pyi # stdlib/datetime.pyi # stdlib/difflib.pyi # stdlib/hashlib.pyi # stdlib/mmap.pyi # stdlib/platform.pyi # stdlib/re.pyi # stdlib/resource.pyi # stdlib/socket.pyi # stdlib/sqlite3/__init__.pyi # stdlib/typing.pyi # stdlib/unittest/_log.pyi # stdlib/wave.pyi
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
# Conflicts: # stdlib/@tests/stubtest_allowlists/py315.txt
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
With lots of other PRs merged, this is now mostly allowlist sorting. |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Part of #15709.
I pointed Codex at the What's New for 3.15 and told it to apply every change relevant to typeshed, then told it to get stubtest running on 3.15 (which found python/cpython#149504) and fix the remaining issues. I also reviewed manually and made a few adjustments (including noticing python/cpython#149534).
Most of the changes were split into smaller PRs; this one now is allowlist sorting plus a few smaller things that were missed. There's a few more allowlist entries that look fixable, but I'll save that for later PRs.