[Authlib] Fix JsonWebKey.import_key typing#15766
Merged
Merged
Conversation
import_key's raw accepts everything that load_pem_key accepts.
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: pandas (https://github.com/pandas-dev/pandas)
+ pandas/core/computation/ops.py:328: error: Need type annotation for "_binary_ops_dict" (hint: "_binary_ops_dict: dict[<type>, <type>] = ...") [var-annotated]
|
srittau
approved these changes
May 11, 2026
Collaborator
srittau
left a comment
srittau
left a comment
There was a problem hiding this comment.
That function is (too) heavily overloaded ... Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import_key'srawaccepts everything thatload_pem_keyaccepts. The function annotation even saysImport a Key from bytes, string, PEM or dictyet it currently only supportsdicttype.https://github.com/authlib/authlib/blob/a0b76fac3fa114d7759af2010546bfc332364b63/authlib/jose/rfc7517/jwk.py#L25-L41
Since the value of
rawis passed down toload_pem_key, it should accept everything that function supports, which is defined intypeshed/stubs/Authlib/authlib/jose/rfc7517/_cryptography_key.pyi
Line 10 in 346d4bd