tkinter: Delete pack_content from Pack and similarly place_content and grid_content#15767
Merged
Conversation
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: pandas (https://github.com/pandas-dev/pandas)
+ pandas/core/computation/ops.py:328: error: Need type annotation for "_binary_ops_dict" (hint: "_binary_ops_dict: dict[<type>, <type>] = ...") [var-annotated]
|
JelleZijlstra
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At runtime, tkinter does this:
This is very similar to #15763, which already deleted the conflicting
contentaliases. This PR deletespack_content,place_contentandgrid_contentfromPack,PlaceandGridclasses. Anything namedfoo_contentin Python 3.15+ tkinter should be just likefoo_slaves, and I have already omittedpack_slaves,grid_slavesandplace_slavesfromPack,GridandPlaceearlier.This PR does not delete
pack_content,place_contentandgrid_contententirely. We still have them inclass Misc(where the are actually defined), and because all widgets inherit fromMiscanyway, these are always available as methods.While these aliases don't conflict like the
contentaliases, they aren't useful either. Nobody seems to be doingtkinter.Grid.grid_content(some_widget)when you could just as well dosome_widget.grid_content().