Conversation
Contributor
|
@q10 has imported this pull request. If you are a Meta employee, you can view this in D120726948. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the ROCm skip guards from 10 SLL Triton test files, enabling 18 previously skipped tests. Four files were skipped at class level (jagged_jagged_bmm, jagged_softmax, jagged_dense_bmm, jagged_dense_elementwise_mul_jagged_out) and six at method level (jagged_self_substraction_jagged_out, jagged_dense_flash_attention, jagged_flash_attention_basic, jagged2_to_padded_dense, dense_jagged_cat_jagged_out, array_jagged_bmm_jagged_out). Each change drops the skipIf decorator and the now unused running_on_rocm import. It also removes a stale entry from the ROCm ignore list in the CI test script.
Motivation
The guards carried only the generic reason string from test_utils.py, "Test currently doesn't work on the ROCm stack", with no per suite rationale. These are Triton kernels and are expected to be hardware portable, so the guards appear to be stale rather than load bearing.