Repository navigation
Conversation
Summary: NOTE: No valid linked task. T279078195 on the related implementation diff is not resolvable by the Tasks service. Add 13 focused regression tests for int32 offset boundaries, cumulative overflow, empty padding inputs, and invalid batch sizes. The tests call the public FBGEMM operators and are intentionally skipped in this lower diff so it remains safe on master. D111289675 is the follow-up implementation diff and enables the test bodies unchanged. Exclude these expected-error and boundary methods from generated opcheck variants; eager execution is enabled by the upper diff. Differential Revision: D120937590
Contributor
|
@q10 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120937590. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
NOTE: No valid linked task. T279078195 on the related implementation diff is not resolvable by the Tasks service.
Add 13 focused regression tests for int32 offset boundaries, cumulative overflow, empty padding inputs, and invalid batch sizes. The tests call the public FBGEMM operators and are intentionally skipped in this lower diff so it remains safe on master. D111289675 is the follow-up implementation diff and enables the test bodies unchanged.
Exclude these expected-error and boundary methods from generated opcheck variants; eager execution is enabled by the upper diff.
Differential Revision: D120937590