Skip to content

Remove non-existent aten.transpose.Dimname overload from quantizer#20076

Open
kirklandsign wants to merge 1 commit into
mainfrom
export-D107688878
Open

Remove non-existent aten.transpose.Dimname overload from quantizer#20076
kirklandsign wants to merge 1 commit into
mainfrom
export-D107688878

Conversation

@kirklandsign
Copy link
Copy Markdown
Contributor

@kirklandsign kirklandsign commented Jun 5, 2026

Summary:
The Arm quantizer's _one_to_one_shared_input_qspec set references
torch.ops.aten.transpose.Dimname at module load time. This named-tensor
overload no longer exists in the currently pinned torch version, so simply
importing quantization_annotator.py raises:

AttributeError: The underlying op of 'aten.transpose' has no overload name 'Dimname'

Because nearly every Arm test imports this module transitively
(test_pipeline -> arm_tester -> quantizer -> quantization_annotator), the
import error broke test listing/collection across the whole Arm backend test
suite (e.g. fbcode//executorch/backends/arm/test:decompose_int_pow_pass failed
at listing with 'collected 0 items / 1 error').

The .Dimname overload is for named tensors, which never appear in exported
edge-dialect graphs, so it is never matched in practice. Removing the line is
safe and restores all Arm tests.

Differential Revision: D107688878

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

Summary:
The Arm quantizer's `_one_to_one_shared_input_qspec` set references
`torch.ops.aten.transpose.Dimname` at module load time. This named-tensor
overload no longer exists in the currently pinned torch version, so simply
importing `quantization_annotator.py` raises:

    AttributeError: The underlying op of 'aten.transpose' has no overload name 'Dimname'

Because nearly every Arm test imports this module transitively
(test_pipeline -> arm_tester -> quantizer -> quantization_annotator), the
import error broke test listing/collection across the whole Arm backend test
suite (e.g. fbcode//executorch/backends/arm/test:decompose_int_pow_pass failed
at listing with 'collected 0 items / 1 error').

The `.Dimname` overload is for named tensors, which never appear in exported
edge-dialect graphs, so it is never matched in practice. Removing the line is
safe and restores all Arm tests.

Differential Revision: D107688878
Copilot AI review requested due to automatic review settings June 5, 2026 19:18
@kirklandsign kirklandsign requested a review from digantdesai as a code owner June 5, 2026 19:18
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Jun 5, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20076

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 3a2c777 with merge base 5af1d7b (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 5, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Jun 5, 2026

@kirklandsign has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107688878.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an import-time failure in the Arm quantizer by removing a reference to a no-longer-existent aten.transpose.Dimname overload, which was breaking Arm backend test discovery/collection.

Changes:

  • Remove torch.ops.aten.transpose.Dimname from the Arm quantizer’s _one_to_one_shared_input_qspec op set to avoid AttributeError at module import time.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@rascani rascani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock, but there's also a duplicate PR here:
#20074

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported module: arm Issues related to arm backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants