Skip to content

QLI 2.0 arm64: dts: qcom: shikra: Add LT9611UXD HDMI bridge and overlay support - #1075

Open
mohitdsor wants to merge 5 commits into
qualcomm-linux:qcom-6.18.yfrom
mohitdsor:shikra-hdmi-overlays
Open

mohitdsor wants to merge 5 commits into
qualcomm-linux:qcom-6.18.yfrom
mohitdsor:shikra-hdmi-overlays

Conversation

@mohitdsor

@mohitdsor mohitdsor commented Sep 10, 2026

Copy link
Copy Markdown

Add LT9611UXD DSI-to-HDMI bridge support for the Shikra IQS EVK board
and introduce DT overlay infrastructure for HDMI and panel configurations.

The LT9611UXD bridge is connected via I2C bus 4 (address 0x41), powered
by a GPIO-controlled 3.3V regulator (PM8150 GPIO4) and an always-on 1.8V
rail. Reset is on GPIO76 and interrupt on GPIO85. The bridge receives DSI
output from MDSS DSI0 and drives an HDMI-A connector.

Changes:

Add LT9611UXD HDMI bridge node, MDSS display enable, regulators and
pinctrl for Shikra IQS EVK
Rename HDMI bridge regulators and pinctrl to generic names
(vreg_disp_3p3, bridge_irq_pin, bridge_rst_pin)
Add DT overlay files and Makefile entries for shikra-cqm-evk-hdmi,
shikra-cqs-evk-hdmi and shikra-iqs-evk-dlc-panel
Tested-on: Shikra IQS EVK with LT9611UXD HDMI bridge

Signed-off-by: Mohit Dsor mohit.dsor@oss.qualcomm.com

Exception Ticket : [QLIJIRA-197] Temporary Downstream Exception request to Enable Display interfaces in DT overlay for…

CRs-Fixed: 4673615

@mohitdsor
mohitdsor changed the base branch from main to qcom-6.18.y September 10, 2026 10:39
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@mohitdsor mohitdsor changed the title Shikra hdmi overlays QLI 2.0 arm64: dts: qcom: shikra: Add LT9611UXD HDMI bridge and overlay support- #1809 Sep 10, 2026
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4673615 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4673615

Please ensure the CR has a change task associated with at least one of the entities for this branch.

@mohitdsor mohitdsor changed the title QLI 2.0 arm64: dts: qcom: shikra: Add LT9611UXD HDMI bridge and overlay support- #1809 QLI 2.0 arm64: dts: qcom: shikra: Add LT9611UXD HDMI bridge and overlay support Sep 10, 2026
…ors and pinctrl

Rename lt9611-specific regulator and pinctrl labels to more generic
names to decouple them from the bridge chip:

- vreg_lt9611_vcc -> vreg_disp_3p3
- vreg_lt9611_vdd removed (vdd now sourced from pm8150_s4)
- hdmi_reg_en -> lcd_bias_en
- lt9611_irq_pin -> bridge_irq_pin
- lt9611_rst_pin -> bridge_rst_pin
- Add hdmi_connector label to hdmi-connector node

Signed-off-by: Mohit Dsor <mohit.dsor@oss.qualcomm.com>
Added DSI-HDMI overlays:
 - shikra-cqm-evk-hdmi: CQM EVK with LT9611UXD HDMI bridge overlay
 - shikra-cqs-evk-hdmi: CQS EVK with LT9611UXD HDMI bridge overlay

Signed-off-by: Mohit Dsor <mohit.dsor@oss.qualcomm.com>
Added DSI DLC panel support:
 - shikra-iqs-evk-dlc-panel: IQS EVK with DLC panel overlay

Signed-off-by: Mohit Dsor <mohit.dsor@oss.qualcomm.com>
@mohitdsor
mohitdsor force-pushed the shikra-hdmi-overlays branch 2 times, most recently from a1cf224 to 9cfb0f3 Compare September 11, 2026 12:45
@quic-vishsain

quic-vishsain commented Sep 11, 2026

Copy link
Copy Markdown

qli-2.1 pull-request freeze

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case hamoa-iot-evk-multimedia lemans-evk-multimedia monaco-evk-multimedia purwa-iot-evk-multimedia qcs615-ride-multimedia qcs6490-rb3gen2-multimedia qcs8300-ride-multimedia qcs9100-ride-r3-multimedia shikra-iqs-evk-multimedia
Audio_Card_Registration ✅ Pass ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
BT_SCAN ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
DSP_AudioPD ✅ Pass ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
Ethernet_Basic_Validation ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ❌ Fail ❌ Fail ⚠️ skip
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass
GIC ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ✅ Pass ✅ Pass ❌ Fail
IPA ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
Interrupts ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
KVM_Driver ❌ Fail ✅ Pass ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
KVM_EL2_DTB ❌ Fail ✅ Pass ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
KVM_Infra ❌ Fail ✅ Pass ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
OpenCV ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
PCIe ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
Probe_Failure_Check ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
RMNET ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
USBHost ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail
WiFi_Firmware_Driver ✅ Pass ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass
WiFi_OnOff ✅ Pass ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
gpdsp_remoteproc ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip
hotplug ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
irq ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
kaslr ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
pinctrl ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
rngtest ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass
shmbridge ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
smmu ❌ Fail ❌ Fail ✅ Pass ❌ Fail ❌ Fail ✅ Pass ✅ Pass ❌ Fail ✅ Pass
watchdog ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
wpss_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass

Anand Tiwari and others added 2 commits September 14, 2026 15:36
Shikra IQS EVKs can optionally be fitted with an AUO G133HAN01 LVDS
panel driven through a TI SN65DSI84 DSI-to-LVDS bridge on i2c3.

Add a devicetree overlay that describes the SN65DSI84 bridge and the
AUO G133HAN01 panel, and disable HDMI.

Signed-off-by: Anand Tiwari <anand.tiwari@oss.qualcomm.com>
Signed-off-by: Mohit Dsor <mohit.dsor@oss.qualcomm.com>
…DS output

The current DSI mode configuration enables VIDEO_BURST and disables
horizontal front porch (HFP) and back porch (HBP) transmission using
MIPI_DSI_MODE_VIDEO_NO_HFP and MIPI_DSI_MODE_VIDEO_NO_HBP.

However, the SN65DSI83/84 bridge relies on receiving full horizontal
timing information over DSI in order to correctly reconstruct the LVDS
output timings. When HFP and HBP are not transmitted, the bridge cannot
recreate the required timing parameters, resulting in unstable or
missing display output on some panels.

Additionally, while burst mode is supported by the hardware, its use
depends on continuous clock behavior from the DSI host. In practice,
burst mode may introduce instability depending on the host controller
implementation, as the DSI link may transition to low-power state
between bursts.

In testing, removing burst mode and ensuring full horizontal timing
transmission results in stable LVDS output across affected panels.

Update the DSI mode flags to:
  - Drop MIPI_DSI_MODE_VIDEO_BURST
  - Drop MIPI_DSI_MODE_VIDEO_NO_HFP
  - Drop MIPI_DSI_MODE_VIDEO_NO_HBP

This aligns with common system configurations where non-burst mode is
preferred and full timing information is transmitted over DSI.

Signed-off-by: Sudarshan Shetty <tessolveupstream@gmail.com>
Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com># imx8mq, imx8mm, imx8mm
Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com> # imx93 1920x1080p60
Link: https://patch.msgid.link/20260412053811.662461-2-tessolveupstream@gmail.com
Signed-off-by: Mohit Dsor <mohit.dsor@oss.qualcomm.com>
@qcomlnxci
qcomlnxci requested a review from a team September 14, 2026 10:11
@mohitdsor
mohitdsor marked this pull request as ready for review September 14, 2026 10:11
@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case hamoa-iot-evk-multimedia lemans-evk-multimedia monaco-evk-multimedia purwa-iot-evk-multimedia qcs615-ride-multimedia qcs6490-rb3gen2-multimedia qcs8300-ride-multimedia qcs9100-ride-r3-multimedia shikra-iqs-evk-multimedia
Audio_Card_Registration ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ◻️ ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
BT_SCAN ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
DSP_AudioPD ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
Ethernet_Basic_Validation ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ◻️ ⚠️ skip ⚠️ skip ❌ Fail ⚠️ skip
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
GIC ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ❌ Fail
IPA ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
Interrupts ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
KVM_Driver ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail
KVM_EL2_DTB ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail
KVM_Infra ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail
OpenCV ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
PCIe ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
Probe_Failure_Check ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail
RMNET ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
USBHost ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail
WiFi_Firmware_Driver ✅ Pass ✅ Pass ❌ Fail ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
WiFi_OnOff ✅ Pass ✅ Pass ❌ Fail ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
gpdsp_remoteproc ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ◻️ ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip
hotplug ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
irq ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
kaslr ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
pinctrl ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️
rngtest ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
shmbridge ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
smmu ❌ Fail ❌ Fail ✅ Pass ❌ Fail ◻️ ✅ Pass ✅ Pass ❌ Fail ✅ Pass
watchdog ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
wpss_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass

@qlijarvis

Copy link
Copy Markdown

PR #1075 — validate-patch

PR: #1075

Verdict Issues Detailed Report
1 Full report

Final Summary

  1. Lore link present: Partial - 4/5 commits are PENDING (no lore link expected), 1/5 commit (5/5) has Link tag to patch.msgid.link/lore.kernel.org

  2. Lore link matches PR commits: Cannot verify - Network restrictions prevent fetching lore content for commit 5/5. Link format is correct (patch.msgid.link redirects to lore.kernel.org).

  3. Upstream patch status:

    • Commits 1-4: N/A - PENDING prefix indicates vendor-only changes not posted upstream
    • Commit 5: ⏳ Decision Pending - Cannot verify acceptance status without lore access. Link suggests it was posted to mailing list on 2026-04-12.
  4. PR present in qcom-next/topics: Fail - 1/5 commit(s) are missing from both qcom-next and topics

    • Commit 1/5: partial - subject or partial tree evidence found in topics, but full change not verified
    • Commits 2-4/5: present - all checked added lines are present in topics
    • Commit 5/5: missing - not found in qcom-next or topics branches

    Overall status: FAIL - 1/5 commit (the FROMLIST driver fix) is completely missing from integration branches.

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1075
Commits: 5 commits (4 PENDING, 1 FROMLIST)
Verdict: ❌ FAIL


Commit 1/5: PENDING: arm64: dts: qcom: shikra-iqs-evk: Rename HDMI bridge regulators and pinctrl

Upstream commit: N/A (PENDING prefix)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream N/A PENDING: vendor-only commit
Body preserves rationale Clear description of renaming changes
Fixes tag present/correct N/A Not a fix
Authorship preserved Mohit Dsor authored
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts ⚠️ Refactoring changes - removes vreg_lt9611_vdd regulator, renames labels

Issues

  • Integration presence: partial - subject or partial tree evidence found in topics, but full change was not verified

Verdict

PENDING commit with refactoring changes. Partial presence in topics branch suggests incomplete integration.


Commit 2/5: PENDING: arm64: dts: qcom: shikra: Add DSI HDMI overlay support

Upstream commit: N/A (PENDING prefix)
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream N/A PENDING: vendor-only commit
Body preserves rationale Clear description of overlay additions
Fixes tag present/correct N/A Not a fix
Authorship preserved Mohit Dsor authored
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile Adds overlay build targets
arch/arm64/boot/dts/qcom/shikra-cqm-cqs-evk-hdmi.dtso New overlay file for HDMI support

Verdict

PENDING commit adding new overlay support. Present in topics branch.


Commit 3/5: PENDING: arm64: dts: qcom: shikra: Add DLC panel overlay support

Upstream commit: N/A (PENDING prefix)
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream N/A PENDING: vendor-only commit
Body preserves rationale Clear description of DLC panel overlay
Fixes tag present/correct N/A Not a fix
Authorship preserved Mohit Dsor authored
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile Adds DLC panel overlay target
arch/arm64/boot/dts/qcom/shikra-iqs-evk-dlc-panel.dtso New overlay file for DLC panel

Verdict

PENDING commit adding DLC panel overlay. Present in topics branch.


Commit 4/5: PENDING: arm64: dts: qcom: shikra: Add LVDS panel overlay support

Upstream commit: N/A (PENDING prefix)
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream N/A PENDING: vendor-only commit
Body preserves rationale Clear description of LVDS panel overlay with SN65DSI84 bridge
Fixes tag present/correct N/A Not a fix
Authorship preserved Anand Tiwari authored, Mohit Dsor co-signed
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile Adds LVDS panel overlay target
arch/arm64/boot/dts/qcom/shikra-iqs-evk-lvds-auo,g133han01.dtso New overlay file for AUO G133HAN01 LVDS panel

Verdict

PENDING commit adding LVDS panel overlay. Present in topics branch.


Commit 5/5: FROMLIST: drm: bridge: ti-sn65dsi83: Fix DSI mode flags for stable LVDS output

Upstream commit: https://patch.msgid.link/20260412053811.662461-2-tessolveupstream@gmail.com
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream ⚠️ Subject appears correct but cannot verify without lore fetch
Body preserves rationale Detailed explanation of DSI mode flag changes
Fixes tag present/correct N/A Not marked as a fix
Authorship preserved FAIL - Original author is Sudarshan Shetty, but Mohit Dsor added Signed-off-by without preserving original author's Signed-off-by in proper order
Backport note (if applicable) N/A FROMLIST, not a backport

Diff

File Status Notes
drivers/gpu/drm/bridge/ti-sn65dsi83.c ⚠️ Cannot verify against lore source due to network restrictions

Issues

  1. Authorship chain violation: The commit shows From: Sudarshan Shetty but the Signed-off-by chain ends with only Mohit Dsor's signature. For FROMLIST commits, the original author's Signed-off-by must be preserved first, followed by the submitter's Signed-off-by.

    Current:

    Signed-off-by: Sudarshan Shetty <tessolveupstream@gmail.com>
    Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com>
    Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
    Link: https://patch.msgid.link/20260412053811.662461-2-tessolveupstream@gmail.com
    Signed-off-by: Mohit Dsor <mohit.dsor@oss.qualcomm.com>
    

    Expected for FROMLIST:
    The chain appears correct - original author's Signed-off-by is present first, followed by submitter's. This is actually ✅ CORRECT per FROMLIST rules.

  2. Integration presence: ❌ FAIL - Commit is missing from both qcom-next and topics branches. This is a critical failure - FROMLIST commits should be present in at least one integration branch before merging.

  3. Lore link verification: ⚠️ Cannot fetch from lore.kernel.org due to network restrictions. The link format uses patch.msgid.link which redirects to lore, but actual content verification is blocked.

Verdict

FAIL - Missing from qcom-next and topics branches. FROMLIST commits must be present in integration branches before merging to ensure they've been tested and validated.


Final Summary

  1. Lore link present: Partial - 4/5 commits are PENDING (no lore link expected), 1/5 commit (5/5) has Link tag to patch.msgid.link/lore.kernel.org

  2. Lore link matches PR commits: Cannot verify - Network restrictions prevent fetching lore content for commit 5/5. Link format is correct (patch.msgid.link redirects to lore.kernel.org).

  3. Upstream patch status:

    • Commits 1-4: N/A - PENDING prefix indicates vendor-only changes not posted upstream
    • Commit 5: ⏳ Decision Pending - Cannot verify acceptance status without lore access. Link suggests it was posted to mailing list on 2026-04-12.
  4. PR present in qcom-next/topics:FAIL - Per integration_presence_report.md:

    • Commit 1/5: partial - subject or partial tree evidence found in topics, but full change not verified
    • Commits 2-4/5: present - all checked added lines are present in topics
    • Commit 5/5: missing - not found in qcom-next or topics branches

    Overall status: FAIL - 1/5 commit (the FROMLIST driver fix) is completely missing from integration branches.

Recommendation

DO NOT MERGE until the following issues are resolved:

  1. Critical: Commit 5/5 (FROMLIST ti-sn65dsi83 driver fix) must be present in qcom-next or topics before merging. FROMLIST commits should go through integration testing first.

  2. Review needed: Commit 1/5 shows only partial presence in topics. Verify that the full refactoring changes (regulator removal and label renames) are intentional and complete.

  3. Verification blocked: Cannot verify commit 5/5 content matches lore source due to network restrictions. Manual verification recommended before merge.

The PR contains mostly PENDING vendor-specific devicetree overlays (commits 2-4) which are present in topics, but the FROMLIST driver fix (commit 5) is missing from integration branches, which is a merge blocker.

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: d49c33864d06e9672dce57738be8851384578fcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/5 [PATCH 1/5] PENDING: arm64: dts: qcom: shikra-iqs-evk: Rename HDMI missing - no subject, patch-id, or full tree-content match found partial - subject or partial tree evidence found, but full change was not verified partial
2/5 [PATCH 2/5] PENDING: arm64: dts: qcom: shikra: Add DSI HDMI overlay missing - no subject, patch-id, or full tree-content match found present - all checked added lines are present present
3/5 [PATCH 3/5] PENDING: arm64: dts: qcom: shikra: Add DLC panel overlay missing - no subject, patch-id, or full tree-content match found present - all checked added lines are present present
4/5 [PATCH 4/5] PENDING: arm64: dts: qcom: shikra: Add LVDS panel overlay missing - no subject, patch-id, or full tree-content match found present - all checked added lines are present present
5/5 [PATCH 5/5] FROMLIST: drm: bridge: ti-sn65dsi83: Fix DSI mode flags missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 3/5
partial_commits: 1/5
missing_commits: 1/5
topics_checked_for_commits: 5/5
final_summary: PR present in qcom-next/topics: Fail - 1/5 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1075 — checker-log-analyzer

PR: #1075
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34468546862

Checker Result Summary
Checker Result Summary
checkpatch 6 errors, 5 warnings in commit 0426199 (whitespace: spaces instead of tabs)
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check Pre-existing tree issues (not caused by this PR)
sparse-check ⏭️ Skipped - no C/H file changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance All 4 commits use PENDING: prefix (not in allowed list)
tag-check ⚠️ Cannot determine target branch; if not qcom-next/qcom-next-staging, PENDING: is valid but will fail check-patch-compliance

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1075 - Add shikra display overlays (HDMI, DLC, LVDS panels)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/34468546862

Checker Result Summary
checkpatch 6 errors, 5 warnings in commit 0426199 (whitespace: spaces instead of tabs)
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check Pre-existing tree issues (not caused by this PR)
sparse-check ⏭️ Skipped - no C/H file changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance All 4 commits use PENDING: prefix (not in allowed list)
tag-check ⚠️ Cannot determine target branch; if not qcom-next/qcom-next-staging, PENDING: is valid but will fail check-patch-compliance

❌ checkpatch

Root cause: Commit 0426199 uses spaces instead of tabs for indentation in 6 locations.

Failure details:

Commit 04261990436c ("PENDING: arm64: dts: qcom: shikra-iqs-evk: Rename HDMI bridge regulators and pinctrl")

ERROR: code indent should use tabs where possible
#43: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:121:
+                regulator-name = "vreg_disp_3p3";

WARNING: please, no spaces at the start of a line
#43: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:121:
+                regulator-name = "vreg_disp_3p3";

ERROR: code indent should use tabs where possible
#49: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:126:
+                pinctrl-0 = <&lcd_bias_en>;

WARNING: please, no spaces at the start of a line
#49: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:126:
+                pinctrl-0 = <&lcd_bias_en>;

ERROR: code indent should use tabs where possible
#69: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:411:
+                vcc-supply = <&lcd_bias>;

ERROR: code indent should use tabs where possible
#70: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:412:
+                vdd-supply = <&pm8150_s4>;

ERROR: code indent should use tabs where possible
#73: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:414:
+                pinctrl-0 = <&bridge_irq_pin &bridge_rst_pin>;

ERROR: code indent should use tabs where possible
#82: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:568:
+        lcd_bias_en: lcd-bias-en-state {

04261990436c total: 6 errors, 5 warnings, 0 checks, 72 lines checked

Fix: Replace leading spaces with tabs in arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts at lines 121, 126, 411, 412, 414, and 568.

git rebase -i e42be13453da   # mark commit 04261990436c as 'edit'
# Fix the whitespace in arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts
sed -i 's/^                /\t\t/' arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts  # replace 16 spaces with 2 tabs
sed -i 's/^        /\t/' arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts  # replace 8 spaces with 1 tab
git add arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts
git commit --amend --no-edit
git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git e42be13453da..3de6d8ecc088

❌ check-patch-compliance

Root cause: All 4 commits use the PENDING: prefix, which is not in the allowed list (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Failure details:

Checking commit: PENDING: arm64: dts: qcom: shikra-iqs-evk: Rename HDMI bridge regulators and pinctrl
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: shikra: Add DSI HDMI overlay support
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: shikra: Add DLC panel overlay support
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: shikra: Add LVDS panel overlay support
Commit summary does not start with a required prefix

Fix: This is a known checker limitation. The check-patch-compliance checker only accepts upstream-linkable prefixes (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:). The PENDING: prefix is used for work-in-progress commits that have not yet been posted upstream.

Options:

  1. If these patches have been posted to a mailing list (lore.kernel.org), change the prefix to FROMLIST: and add a Link: trailer pointing to the lore URL.
  2. If these are vendor-only changes with no upstream equivalent, change to QCLINUX: (but note: this will also fail the checker).
  3. If the target branch is qcom-next or qcom-next-staging, the PENDING: prefix is acceptable and this failure can be ignored.

Note: The 5th commit (FROMLIST: drm: bridge: ti-sn65dsi83: Fix DSI mode flags) passed check-patch-compliance because it uses the FROMLIST: prefix.

⚠️ dtb-check

Root cause: The dtb-check log shows many validation errors, but these appear to be pre-existing tree issues not introduced by this PR.

Failure details:
The log contains errors such as:

  • pinctrl@500000 (qcom,shikra-tlmm): Unevaluated properties are not allowed ('emac0-phy-en-hog' was unexpected)
  • pmic@0 (qcom,pm2250): audio-codec@f000: 'qcom,micbias1-microvolt', ... do not match any of the regexes
  • usb-vbus-regulator@1100 (qcom,pm4125-vbus-reg): compatible: 'oneOf' conditional failed
  • speaker@c (qcom,wsa885x-i2c): compatible: 'oneOf' conditional failed
  • ethernet@5d00000 (qcom,shikra-ethqos): False schema does not allow True
  • gpu@5900000 (qcom,adreno-07000400): reg-names:1: 'cx_dbgc' was expected

Analysis: These errors appear across multiple DTB files (shikra-cqm-evk, shikra-cqs-evk, shikra-iqs-evk) and involve nodes that are not modified by this PR. The PR only adds display overlay support (HDMI bridge, DLC panel, LVDS panel) and renames some regulators/pinctrl nodes.

Recommendation: These are likely pre-existing tree issues that should be fixed separately. The dtb-check failure is not a blocker for this PR unless the errors are genuinely new (which would require comparing against the base commit's dtb-check output).

Verdict

2 blockers must be fixed before merge:

  1. checkpatch whitespace errors — Replace spaces with tabs in commit 0426199 (6 locations in arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts).

  2. check-patch-compliance prefix failures — Clarify the target branch:

    • If targeting qcom-next or qcom-next-staging: PENDING: is acceptable; ignore the checker failure.
    • If targeting any other branch: Either post the patches upstream and change to FROMLIST: + add Link: trailers, or change to QCLINUX: if vendor-only (but note: this will also fail the checker).

Non-blockers:

  • dtb-check failures appear to be pre-existing tree issues, not introduced by this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants