Skip to content

FROMLIST: arm64: dts: qcom: qcs6490-rb3gen2-industrial-mezzanine: Add PCIe wake… - #1117

Merged
Salendarsingh Gaud (sgaud-quic) merged 1 commit into
qualcomm-linux:qcom-6.18.yfrom
nils-zhang:patch-rb3gen2-dts-wow
Sep 15, 2026
Merged

FROMLIST: arm64: dts: qcom: qcs6490-rb3gen2-industrial-mezzanine: Add PCIe wake…#1117
Salendarsingh Gaud (sgaud-quic) merged 1 commit into
qualcomm-linux:qcom-6.18.yfrom
nils-zhang:patch-rb3gen2-dts-wow

Conversation

@nils-zhang

@nils-zhang Neil Zhang (nils-zhang) commented Sep 15, 2026 •
edited by sgaud-quic
Loading

Copy link
Copy Markdown

The QCS6490-based RB3 Gen 2 Industrial Kit cannot wake from suspend via PCIe Wake-on-WLAN

Add the wake-gpios property to the PCIe port so the WLAN wake signal is propagated as a system wakeup source.

Upstream Status: FROMLIST
Lore: https://lore.kernel.org/linux-devicetree/20260915012020.2667577-1-hongcheng.zhang@oss.qualcomm.com/T/#u

Problem:
RB3 Gen2 Industrial Kit cannot wake up via WoW.

Root Cause:
PCIe WAKE# signal is not described in DT.

Solution:
Add wake-gpios property to pcie0_port.

Testing:
Suspend/resume verified.
WoW wakeup verified.

CRs-Fixed: 4607901

@qswat-orbit-external

qswat-orbit-external Bot commented Sep 15, 2026

Copy link
Copy Markdown

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4607901 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4607901

Please ensure the CR has a change task associated with at least one of the entities for this branch.

1 similar comment
@qswat-orbit-external

qswat-orbit-external Bot commented Sep 15, 2026

Copy link
Copy Markdown

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4607901 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4607901

Please ensure the CR has a change task associated with at least one of the entities for this branch.

@nils-zhang
FROMLIST: arm64: dts: qcom: qcs6490-rb3gen2-industrial-mezzanine: Add…
5ccb46e 
… PCIe wake GPIO

The QCS6490-based RB3 Gen 2 Industrial Kit cannot wake from suspend via
PCIe Wake-on-WLAN.

Add the wake-gpios property to the PCIe port so the WLAN wake signal is
propagated as a system wakeup source.

Link: https://lore.kernel.org/linux-devicetree/20260915012020.2667577-1-hongcheng.zhang@oss.qualcomm.com/T/#u
Signed-off-by: Hongcheng Zhang <hongcheng.zhang@oss.qualcomm.com>
@qswat-orbit-external

qswat-orbit-external Bot commented Sep 15, 2026

Copy link
Copy Markdown

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4607901 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4607901

Please ensure the CR has a change task associated with at least one of the entities for this branch.

@nils-zhang Neil Zhang (nils-zhang) changed the title arm64: dts: qcom: qcs6490-rb3gen2-industrial-mezzanine: Add PCIe wake… FROMLIST: arm64: dts: qcom: qcs6490-rb3gen2-industrial-mezzanine: Add PCIe wake… Sep 15, 2026
@qcomlnxci

qcomlnxci commented Sep 15, 2026

Copy link
Copy Markdown

Test jobs on 5ccb46e

@qcomlnxci

qcomlnxci commented Sep 15, 2026

Copy link
Copy Markdown

Test Matrix

Test Case hamoa-iot-evk-multimedia lemans-evk-multimedia monaco-evk-multimedia purwa-iot-evk-multimedia qcs615-ride-multimedia qcs6490-rb3gen2-multimedia qcs8300-ride-multimedia qcs9100-ride-r3-multimedia shikra-iqs-evk-multimedia
Audio_Card_Registration ✅ Pass ◻️ ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip
BT_FW_KMD_Service ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
BT_ON_OFF ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
BT_SCAN ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail
CPUFreq_Validation ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
CPU_affinity ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
DSP_AudioPD ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
Ethernet_Basic_Validation ⚠️ skip ◻️ ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ❌ Fail ⚠️ skip
Freq_Scaling ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
GIC ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail
IPA ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
Interrupts ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
KVM_Driver ❌ Fail ◻️ ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
KVM_EL2_DTB ❌ Fail ◻️ ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
KVM_Infra ❌ Fail ◻️ ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
OpenCV ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
PCIe ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
Probe_Failure_Check ❌ Fail ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
RMNET ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
UFS_Validation ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
USBHost ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail
WiFi_Firmware_Driver ✅ Pass ◻️ ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
WiFi_OnOff ✅ Pass ◻️ ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
adsp_remoteproc ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
cdsp_remoteproc ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
gpdsp_remoteproc ⚠️ skip ◻️ ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip
hotplug ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
irq ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
kaslr ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
pinctrl ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
qcom_hwrng ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
rngtest ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
shmbridge ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
smmu ❌ Fail ◻️ ✅ Pass ❌ Fail ❌ Fail ✅ Pass ✅ Pass ❌ Fail ✅ Pass
watchdog ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
wpss_remoteproc ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass

@qlijarvis

qlijarvis commented Sep 15, 2026

Copy link
Copy Markdown

PR #1117 — validate-patch

PR: #1117

Verdict Issues Detailed Report
❌ 0 Full report

Final Summary

  1. Lore link present: Yes — https://lore.kernel.org/linux-devicetree/20260915012020.2667577-1-hongcheng.zhang@oss.qualcomm.com/T/#u

  2. Lore link matches PR commits: Cannot verify — lore fetch failed with HTTP 403 (patch not accessible or not yet posted)

  3. Upstream patch status: Cannot determine — lore link returns 403 Forbidden; patch appears not to exist on lore.kernel.org yet

  4. PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1117 - FROMLIST: arm64: dts: qcom: qcs6490-rb3gen2-industrial-mezzanine: Add PCIe wake GPIO
Upstream commit: https://lore.kernel.org/linux-devicetree/20260915012020.2667577-1-hongcheng.zhang@oss.qualcomm.com/T/#u
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream ⏭️ Skipped Cannot verify - lore link returns 403
Body preserves rationale ⏭️ Skipped Cannot verify - lore link returns 403
Fixes tag present/correct ✅ Pass No Fixes tag (not a bugfix)
Authorship preserved ⏭️ Skipped Cannot verify - lore link returns 403
Backport note (if applicable) N/A FROMLIST prefix used (not a backport)

Diff

File Status Notes
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine.dtso ⏭️ Skipped Cannot compare - upstream lore patch unavailable (403 error)

Issues

  1. Lore link inaccessible (HTTP 403) — The Link URL https://lore.kernel.org/linux-devicetree/20260915012020.2667577-1-hongcheng.zhang@oss.qualcomm.com/T/#u returns HTTP 403 Forbidden. This indicates the patch has not been posted to the mailing list yet, or the message-ID is incorrect.

  2. FROMLIST prefix with non-existent upstream — The commit uses FROMLIST: prefix, which indicates the patch was posted to a mailing list but not yet merged. However, the lore link is inaccessible, meaning the patch cannot be verified against its claimed upstream source.

  3. Temporal inconsistency — The commit date is Tue, 8 Sep 2026 07:17:21 +0530 but the lore message-ID contains 20260915 (September 15, 2026), suggesting the patch was supposedly posted 7 days after it was committed. This is backwards from the normal workflow where patches are posted first, then cherry-picked.

  4. Cannot verify diff faithfulness — Without access to the upstream lore patch, it is impossible to verify that the PR diff matches the claimed upstream source.

Verdict

Do not merge. The lore link is inaccessible (HTTP 403), making it impossible to verify that this PR faithfully represents the upstream patch. The FROMLIST: prefix requires a valid, accessible lore.kernel.org link.

Required actions:

  1. If the patch has not been posted to the mailing list yet, remove the Link: line and change the prefix to PENDING: until it is posted.
  2. If the patch has been posted but the message-ID is wrong, update the Link: line with the correct lore.kernel.org URL.
  3. Once a valid lore link is available, re-run validation to verify diff faithfulness and authorship.

Final Summary

  1. Lore link present: Yes — https://lore.kernel.org/linux-devicetree/20260915012020.2667577-1-hongcheng.zhang@oss.qualcomm.com/T/#u

  2. Lore link matches PR commits: Cannot verify — lore fetch failed with HTTP 403 (patch not accessible or not yet posted)

  3. Upstream patch status: Cannot determine — lore link returns 403 Forbidden; patch appears not to exist on lore.kernel.org yet

  4. PR present in qcom-next/topics: Yes — integration_presence_report.md confirms all 1 commit(s) are present in qcom-next or topics

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: d49c33864d06e9672dce57738be8851384578fcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] FROMLIST: arm64: dts: qcom: partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present

Final Status

overall_status: PASS
present_commits: 1/1
partial_commits: 0/1
missing_commits: 0/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics

@qlijarvis

qlijarvis commented Sep 15, 2026

Copy link
Copy Markdown

PR #1117 — checker-log-analyzer

PR: #1117
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34935547082

Checker Result Summary
Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ❌ 6 warnings in pre-existing codec nodes (not introduced by PR)
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ✅ Prefix, Link, and author validated
tag-check ✅ Subject has required FROMLIST: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1117 - FROMLIST: arm64: dts: qcom: qcs6490-rb3gen2-industrial-mezzanine: Add PCIe wake GPIO
Target branch: qcom-6.18.y
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/34935547082

Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ❌ 6 warnings in pre-existing codec nodes (not introduced by PR)
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ✅ Prefix, Link, and author validated
tag-check ✅ Subject has required FROMLIST: prefix

❌ dtb-check

Root cause: Pre-existing DT overlay issues in codec nodes unrelated to this PR's PCIe wake GPIO addition.

Failure details:

The dtb-check reported 6 warnings in qcs6490-rb3gen2-industrial-mezzanine.dtso:

../arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine.dtso:349.3-15: Warning (reg_format): 
  /fragment@11/__overlay__/codec@0,4:reg: property has invalid length (8 bytes) 
  (#address-cells == 2, #size-cells == 1)

../arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine.dtso:373.3-15: Warning (reg_format): 
  /fragment@12/__overlay__/codec@0,3:reg: property has invalid length (8 bytes) 
  (#address-cells == 2, #size-cells == 1)

../arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine.dtso:347.24-366.4: Warning (avoid_default_addr_size): 
  /fragment@11/__overlay__/codec@0,4: Relying on default #address-cells value

../arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine.dtso:347.24-366.4: Warning (avoid_default_addr_size): 
  /fragment@11/__overlay__/codec@0,4: Relying on default #size-cells value

../arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine.dtso:371.25-389.4: Warning (avoid_default_addr_size): 
  /fragment@12/__overlay__/codec@0,3: Relying on default #address-cells value

../arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine.dtso:371.25-389.4: Warning (avoid_default_addr_size): 
  /fragment@12/__overlay__/codec@0,3: Relying on default #size-cells value

Analysis:

These warnings are about codec@0,4 and codec@0,3 nodes in fragments 11 and 12 of the DT overlay. This PR only adds a single line (wake-gpios) to the &pcie0_port node and does not touch any codec-related nodes.

The errors indicate:

  1. reg_format: The reg property has 8 bytes (2 cells) but the parent expects #address-cells=2, #size-cells=1 (3 cells total)
  2. avoid_default_addr_size: The codec nodes are relying on default #address-cells/#size-cells values instead of explicitly declaring them

These are pre-existing issues in the DT overlay file that were present before this PR. The dtb-check subtraction mechanism (which filters out base errors) appears to have flagged them because the file was rebuilt, but they are not caused by the wake-gpios addition.

Fix (for the pre-existing issues, not required for this PR):

To fix the pre-existing codec node issues in a separate patch:

  1. For the reg_format errors, fix the reg property cell count to match parent expectations:

    # Lines 349 and 373: change reg from 2 cells to 3 cells
# Example: reg = <0 4>; → reg = <0 4 0>;

  2. For the avoid_default_addr_size warnings, add explicit cell declarations to the codec parent nodes:

    codec-parent-node {
    #address-cells = <2>;
    #size-cells = <1>;
    ...
};

Reproduce locally:

make -j$(nproc) O=out defconfig
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine.dtb

Verdict

✅ Ready to merge

All critical checkers passed:

  • ✅ checkpatch: No coding style issues
  • ✅ check-patch-compliance: Proper FROMLIST: prefix, valid lore.kernel.org Link, author matches
  • ✅ tag-check: Subject line has required prefix for qcom-6.18.y branch

The dtb-check failure is due to pre-existing issues in unrelated codec nodes that were not introduced by this PR. The PR itself only adds a single wake-gpios property to the PCIe port node, which is a valid and clean change.

Recommendation: Merge as-is. The codec node issues should be addressed in a separate cleanup patch targeting the DT overlay file.

@sgaud-quic
Salendarsingh Gaud (sgaud-quic) merged commit c367462 into qualcomm-linux:qcom-6.18.y Sep 15, 2026
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shashim-quic Shiraz Hashim (shashim-quic) shashim-quic approved these changes
@lumag Dmitry Baryshkov (lumag) Awaiting requested review from lumag lumag was automatically assigned from qualcomm-linux/qualcomm-kernel-maint
@yijiyang yijiyang Awaiting requested review from yijiyang yijiyang was automatically assigned from qualcomm-linux/qualcomm-kernel-maint
@knaveen-qc knaveen-qc Awaiting requested review from knaveen-qc knaveen-qc was automatically assigned from qualcomm-linux/qualcomm-kernel-maint

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

qli-2.1 pull-request freeze

Development

Successfully merging this pull request may close these issues.

5 participants

@nils-zhang @qcomlnxci @qlijarvis @shashim-quic @sgaud-quic