Repository navigation
FROMLIST: arm64: dts: qcom: shikra-iqs: add M.2 Wi-Fi and Bluetooth overlay - #1267
Conversation
|
Merge Check Failed: No CR Numbers Found Error: No Change Request numbers were found. Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests. |
Shiraz Hashim (shashim-quic)
left a comment
There was a problem hiding this comment.
Please submit the change upstream and bring as FROMLIST. Make sure subject is rightly prefixed and Link: tag is included in commit log pointing to submitted lore patch.
ee5c9fa to
7f48fa5
Compare
|
Merge Check Failed: No CR Numbers Found Error: No Change Request numbers were found. Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests. |
7f48fa5 to
0267f40
Compare
|
Merge Check Failed: No CR Numbers Found Error: No Change Request numbers were found. Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests. |
Dmitry Baryshkov (lumag)
left a comment
There was a problem hiding this comment.
Disable
the onboard Wi-Fi and Bluetooth nodes when the overlay is selected
Why? Don't describe patch contents, it's obvious from the patch. Describe the reasons for the changes. Having multiple WiFI cards is perfectly fine.
| }; | ||
|
|
||
| &tc9563 { | ||
| reg = <0x1ff00 0x0 0x0 0x0 0x0>; |
There was a problem hiding this comment.
Why are you overriding reg and then immediately disabling the device?
There was a problem hiding this comment.
The inherited TC9563 node still retains its original PCI reg and compatible = "pci1179,0623". Although status = "disabled" prevents the TC9563 power-control device from probing, the PCI OF matching code can still associate that stale OF node with the QCC2072 endpoint enumerated at the same PCI address. As a result, ath12k sees the TC9563 OF node instead of the directly connected QCC2072 endpoint and fails to bind with -ENODEV.
Moving the disabled node to an unused PCI address prevented that stale OF-node association during our testing. That is why the patch both overrides reg and disables the node.
PR #1267 — validate-patchPR: #1267
Final Summary
|
PR #1267 — checker-log-analyzerPR: #1267
Detailed report: Full report
|
0267f40 to
8770ff8
Compare
|
Merge Check Failed: No CR Numbers Found Error: No Change Request numbers were found. Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests. |
PR #1267 — validate-patchPR: #1267
Final Summary
|
PR #1267 — checker-log-analyzerPR: #1267
Detailed report: Full report
|
8770ff8 to
127d678
Compare
|
Merge Check Failed: No CR Numbers Found Error: No Change Request numbers were found. Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests. |
127d678 to
b15f6f0
Compare
|
Merge Check Failed: No CR Numbers Found Error: No Change Request numbers were found. Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests. |
|
Merge Check Failed: CR Not Eligible for Merge CR 4706433 is not eligible for merge. The parent software image for kernel.qli.2.0 is not development complete. Entity: Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations. |
PR #1267 — validate-patchPR: #1267
Final Summary
|
PR #1267 — checker-log-analyzerPR: #1267
Detailed report: Full report
|
Dmitry Baryshkov (lumag)
left a comment
There was a problem hiding this comment.
The patch has known issues reported by Sashiko. Also please read the documentation about sending patches to the Linux kernel. For example, don't send new iterations as replies to the previous versions.
🔨 Build Failure Analysis — PR #1267PR: #1267
VerdictThis is not a PR-introduced error. The PR requires a rebase on the current 📎 Detailed analysis: Full report |
Test Matrix
|
PR #1267 — validate-patchPR: #1267
Final Summary
|
PR #1267 — checker-log-analyzerPR: #1267
Detailed report: Full report
|
LAVA Failed Case Triage SummaryPR: #1267 Job 261142 | SoC purwa-evkLAVA job: https://lava-oss.qualcomm.com/scheduler/job/261142 Failed test cases in LAVA job 261142 (SoC: purwa-evk).
Job 261143 | SoC shikra-iqs-evkLAVA job: https://lava-oss.qualcomm.com/scheduler/job/261143 Failed test cases in LAVA job 261143 (SoC: shikra-iqs-evk).
Job 261144 | SoC lemans-evkLAVA job: https://lava-oss.qualcomm.com/scheduler/job/261144 Failed test cases in LAVA job 261144 (SoC: lemans-evk).
Job 261145 | SoC hamoa-evkLAVA job: https://lava-oss.qualcomm.com/scheduler/job/261145 Failed test cases in LAVA job 261145 (SoC: hamoa-evk).
Job 261146 | SoC qcs615-rideLAVA job: https://lava-oss.qualcomm.com/scheduler/job/261146 Failed test cases in LAVA job 261146 (SoC: qcs615-ride).
Job 261147 | SoC qcs8300-rideLAVA job: https://lava-oss.qualcomm.com/scheduler/job/261147 Failed test cases in LAVA job 261147 (SoC: qcs8300-ride).
Job 261148 | SoC monaco-evkLAVA job: https://lava-oss.qualcomm.com/scheduler/job/261148 Failed test cases in LAVA job 261148 (SoC: monaco-evk).
Job 261149 | SoC qcs6490-rb3gen2LAVA job: https://lava-oss.qualcomm.com/scheduler/job/261149 Failed test cases in LAVA job 261149 (SoC: qcs6490-rb3gen2).
Job 261150 | SoC qcs9100-rideLAVA job: https://lava-oss.qualcomm.com/scheduler/job/261150 Failed test cases in LAVA job 261150 (SoC: qcs9100-ride).
|
Dmitry Baryshkov (lumag)
left a comment
There was a problem hiding this comment.
Change-Id: I12636752da4bef5b6be80ce3e75098994779acdf
No Gerrit, thanks.
Add an overlay for M.2 Key-E Wi-Fi and Bluetooth modules on the Qualcomm
Shikra IQS EVK.
Don't duplicate the title. Start by describing the issue.
Disable the onboard
Wi-Fi and Bluetooth nodes when the overlay
Why? Is the hardware also disabled on board? If so, how? Using the DIP switch or somehow else?
937a6f2 to
0ce7c05
Compare
|
PR #1267 — validate-patchPR: #1267
Final Summary
|
PR #1267 — checker-log-analyzerPR: #1267
Detailed report: Full report
|
|
0ce7c05 to
d17508a
Compare
…verlay The Shikra product design supports either the onboard Apache WCN3988 path or the M.2 HSP Cologne path at a time; the two connectivity paths are not intended to operate simultaneously. The overlay describes the board after hardware rework selects the M.2 path, where the onboard connectivity device is unavailable. Describe the PCIe and UART connections through the M.2 connector, the 3.3 V supply, the W_DISABLE signals and the PCIe reset signal. The Wi-Fi PCIe path was tested with a QCC2072 module. The overlay was applied, the link trained at Gen2 x1, the endpoint enumerated, and ath12k started MHI. The Bluetooth UART and HCI path was also tested and the QCC2072 controller initialized successfully. Link: https://lore.kernel.org/r/20261102045815.2938940-1-linghui.wu@oss.qualcomm.com Co-developed-by: Wei Deng <wei.deng@oss.qualcomm.com> Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com> Signed-off-by: Linghui Wu <linghui.wu@oss.qualcomm.com>
d17508a to
dc3242b
Compare
PR #1267 — validate-patchPR: #1267
Final Summary
|
PR #1267 — checker-log-analyzerPR: #1267
Detailed report: Full report
|
Test Matrix
|
Test Matrix
|
Test Matrix
|
The M.2 variant uses the external module connected through the Key-E
connector instead of the onboard WCN3988 devices. Disable the onboard
Wi-Fi and Bluetooth nodes when the overlay is selected so the device tree
matches the hardware variant and does not probe the unavailable onboard
connectivity path.
Describe the PCIe and UART connections through the M.2 connector, the
3.3 V supply, the W_DISABLE signals and the PCIe reset signal.
The Wi-Fi PCIe path was tested on a Shikra IQS EVK with a QCC2072
module. The overlay was applied, the link trained at Gen2 x1 and the
endpoint enumerated. Bluetooth UART and HCI runtime validation is
pending.
Link: https://lore.kernel.org/r/20261102045815.2938940-1.linghui.wu@oss.qualcomm.com
CRs-Fixed: 4706433
Co-developed-by: Wei Deng wei.deng@oss.qualcomm.com
Signed-off-by: Wei Deng wei.deng@oss.qualcomm.com
Signed-off-by: Linghui Wu linghui.wu@oss.qualcomm.com