Akash/shikra usb role switch fix by akakum-qualcomm · Pull Request #1374 · qualcomm-linux/kernel

akakum-qualcomm · 2026-11-01T18:03:38Z

arm64: dts: qcom: shikra: Rework USB SS endpoint wiring

Add a dedicated usb_1_dwc3_ss_out endpoint port on usb_1_dwc3_ss and
rewire remote-endpoint references so the QMP PHY and UCSI CCG SS
endpoints connect through it instead of directly to usb_1_dwc3_ss.

Signed-off-by: Akash Kumar <akakum@qti.qualcomm.com>

qswat-orbit-external · 2026-11-01T18:03:46Z

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

qswat-orbit-external · 2026-11-01T18:04:38Z

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

qswat-orbit-external · 2026-11-01T18:05:39Z

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

qswat-orbit-external · 2026-11-01T18:06:38Z

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

qswat-orbit-external · 2026-11-02T08:16:46Z

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

qlijarvis · 2026-11-02T09:32:36Z

PR #1374 — validate-patch

PR: #1374

Verdict	Issues	Detailed Report
❌	0	Full report

Final Summary

Lore link present: No — no lore.kernel.org Link tags found in any of the 4 commits
Lore link matches PR commits: N/A — no lore link to compare against
Upstream patch status: N/A — no vendor prefix or lore link; cannot determine if these are vendor-only, pending upstream, or abandoned debug work
PR present in qcom-next/topics: Fail - 1/4 commit(s) are missing from both qcom-next and topics

Recommended Actions:

If this is debug/test work: Close the PR or convert to a draft. Debug instrumentation should not be merged to integration branches.
If commit 1/4 is a legitimate fix:
- Remove the "TEst1" test artifact from the model string
- Remove the commented-out code
- Add a proper commit message body explaining the USB SS endpoint rewiring
- Add appropriate vendor prefix (QCLINUX: if vendor-only, or FROMLIST:/UPSTREAM: with lore link if posted upstream)
If commits 2/4 and 3/4 are needed for debugging:
- Keep them in a local debug branch, do not merge to qcom-next or integration branches
PR present in qcom-next/topics: Fail - 1/4 commit(s) are missing from both qcom-next and topics
- Split into 3 separate commits:
  a) GDSC power state changes (with explanation of why PWRSTS_RET_ON is needed)
  b) UCSI CCG GPIO orientation handling (with proper commit message)
  c) Remove the "TEst2" test artifact entirely
- Add vendor prefixes and lore links as appropriate

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1374 - USB SS endpoint wiring and debug changes
Upstream commit: N/A (no lore links found)
Verdict: ❌ FAIL

Commit Message

Check Status Note

Subject matches upstream ❌ No upstream lore link to compare against

Body preserves rationale ❌ Commits 2/4, 3/4, 4/4 have no commit message body

Fixes tag present/correct ❌ No Fixes tags present in any commit

Authorship preserved N/A No upstream source to verify against

Backport note (if applicable) N/A Not a backport

Diff

File Status Notes

arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts ❌ Contains test artifacts: "TEst1" (commit 1/4) and "TEst2" (commit 4/4) in model string

arch/arm64/boot/dts/qcom/shikra.dtsi ⚠️ Commented-out code present: //remote-endpoint = <&usb_qmpphy_usb_ss_in>;

drivers/usb/dwc3/core.c ❌ Debug macro redefinitions (#undef dev_dbg / #define dev_dbg dev_err) - not suitable for production

drivers/usb/dwc3/dwc3-qcom.c ❌ Debug logging with dump_stack() calls - not suitable for production

drivers/usb/dwc3/gadget.c ❌ Debug logging additions

drivers/phy/qualcomm/phy-qcom-qmp-usbc.c ❌ Debug logging with dump_stack() and pr_err

drivers/usb/typec/class.c ❌ Debug logging with dump_stack()

drivers/usb/typec/ucsi/ucsi.c ❌ Debug logging additions

drivers/usb/typec/ucsi/ucsi_ccg.c ⚠️ Mix of debug logging and functional GPIO orientation handling code

drivers/usb/typec/ucsi/ucsi_glink.c ❌ Debug logging additions

drivers/clk/qcom/gcc-shikra.c ⚠️ GDSC power state changes (PWRSTS_OFF_ON → PWRSTS_RET_ON) without explanation

Issues

Critical Issues:

No vendor prefix on any commit - All 4 commits lack required vendor prefixes (UPSTREAM:, FROMLIST:, BACKPORT:, QCLINUX:, PENDING:, WORKAROUND:). Cannot determine intent or upstream status.

No lore.kernel.org links - No Link: tags present in any commit message. Required for UPSTREAM:/FROMLIST:/BACKPORT: commits.

Test artifacts in production code:

Commit 1/4: model = "Qualcomm Technologies, Inc. Shikra IQS EVK TEst1"; (typo: "TEst1")

Commit 4/4: model = "Qualcomm Technologies, Inc. Shikra IQS EVK TEst2"; (typo: "TEst2")

These appear to be test markers that should not be committed.

Debug code not suitable for production:

Commit 2/4: Redefines dev_dbg → dev_err, dev_info → dev_err, pr_debug → pr_err globally in dwc3/core.c

Commits 2/4, 3/4: Multiple dump_stack() calls in hot paths (typec_switch_set, dwc3_qcom_set_role_notifier)

This debug instrumentation floods dmesg and impacts performance - not acceptable for mainline or production branches.

Missing commit message bodies:

Commit 2/4: Subject "debug logs usb" with no explanation

Commit 3/4: Subject "debug logs ucsi orientation issue" with no explanation

Commit 4/4: Subject "ucsi ccg role switch issue" with no explanation

Kernel commits require a body explaining why the change is needed.

Commented-out code:

Commit 1/4 in shikra.dtsi: //remote-endpoint = <&usb_qmpphy_usb_ss_in>;

Commented code should be removed, not left in the tree.

Unexplained functional changes:

Commit 4/4 changes GDSC power states in gcc-shikra.c (PWRSTS_OFF_ON → PWRSTS_RET_ON) with no commit message explanation.

This is a significant power management change that requires justification.

Mixed concerns in single commit:

Commit 4/4 combines: DTS test string change + clock driver GDSC changes + UCSI CCG GPIO orientation feature

These are unrelated changes and should be split into separate commits.

Verdict

Do not merge. This PR contains test/debug code that is not suitable for any production branch. The commits lack proper formatting, vendor prefixes, commit messages, and contain test artifacts.

Final Summary

Lore link present: No — no lore.kernel.org Link tags found in any of the 4 commits

Lore link matches PR commits: N/A — no lore link to compare against

Upstream patch status: N/A — no vendor prefix or lore link; cannot determine if these are vendor-only, pending upstream, or abandoned debug work

PR present in qcom-next/topics: Fail - 1/4 commit(s) are missing from both qcom-next and topics; 3/4 are partial matches (per integration_presence_report.md)

Recommended Actions:

If this is debug/test work: Close the PR or convert to a draft. Debug instrumentation should not be merged to integration branches.

If commit 1/4 is a legitimate fix:

Remove the "TEst1" test artifact from the model string

Remove the commented-out code

Add a proper commit message body explaining the USB SS endpoint rewiring

Add appropriate vendor prefix (QCLINUX: if vendor-only, or FROMLIST:/UPSTREAM: with lore link if posted upstream)

If commits 2/4 and 3/4 are needed for debugging:

Keep them in a local debug branch, do not merge to qcom-next or integration branches

If commit 4/4 contains legitimate fixes:

Split into 3 separate commits:
a) GDSC power state changes (with explanation of why PWRSTS_RET_ON is needed)
b) UCSI CCG GPIO orientation handling (with proper commit message)
c) Remove the "TEst2" test artifact entirely

Add vendor prefixes and lore links as appropriate

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 17bbb4b37bbc4fc5827b4667445a0c43967c0f48
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final

1/4 [PATCH 1/4] arm64: dts: qcom: shikra: Rework USB SS endpoint wiring partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial

2/4 [PATCH 2/4] debug logs usb partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial

3/4 [PATCH 3/4] debug logs ucsi orientation issue missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

4/4 [PATCH 4/4] ucsi ccg role switch issue partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial

Final Status

overall_status: FAIL
present_commits: 0/4
partial_commits: 3/4
missing_commits: 1/4
topics_checked_for_commits: 4/4
final_summary: PR present in qcom-next/topics: Fail - 1/4 commit(s) are missing from both qcom-next and topics

qlijarvis · 2026-11-02T09:32:38Z

PR #1374 — checker-log-analyzer

PR: #1374
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/41411996638

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	3 of 4 commits have style issues: missing Signed-off-by, spacing errors, long lines, missing commit descriptions
dt-binding-check	⏭️	No DT binding changes
dtb-check	✅	Passed
sparse-check	✅	Passed
check-uapi-headers	✅	Passed
check-patch-compliance	❌	All 4 commits missing required subject prefix
tag-check	❌	All 4 commits missing required subject prefix (assuming non-qcom-next branch)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1374 - USB debugging and orientation fixes
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/41411996638

Checker Result Summary

checkpatch ❌ 3 of 4 commits have style issues: missing Signed-off-by, spacing errors, long lines, missing commit descriptions

dt-binding-check ⏭️ No DT binding changes

dtb-check ✅ Passed

sparse-check ✅ Passed

check-uapi-headers ✅ Passed

check-patch-compliance ❌ All 4 commits missing required subject prefix

tag-check ❌ All 4 commits missing required subject prefix (assuming non-qcom-next branch)

❌ checkpatch

Root cause: Three commits (2/4, 3/4, 4/4) contain debug logging code with multiple coding style violations and all three are missing Signed-off-by trailers.

Failure details:

Commit a3339f9 ("debug logs usb"):
ERROR: Missing Signed-off-by: line(s)
WARNING: Missing commit description - Add an appropriate one
WARNING: line length of 103 exceeds 100 columns
#58: FILE: drivers/usb/dwc3/core.c:2654:
+		dev_info(dwc->dev, "dwc3-pmdbg: runtime_suspend: suspend_common failed ret=%d\n", ret);
WARNING: line length of 109 exceeds 100 columns
#165: FILE: drivers/usb/dwc3/dwc3-qcom.c:830:
+		dev_info(dev, "dwc3-pmdbg: qcom_runtime_suspend: dwc3_runtime_suspend failed ret=%d\n", ret);

total: 1 errors, 3 warnings, 0 checks, 215 lines checked
Commit be4735a ("debug logs ucsi orientation issue"):
ERROR: Missing Signed-off-by: line(s)
WARNING: Missing commit description - Add an appropriate one
ERROR: space required after that ',' (ctx:VxV) — 13 instances across multiple files
ERROR: space prohibited before that close parenthesis ')' — 2 instances
ERROR: trailing whitespace
#72: FILE: drivers/usb/typec/class.c:2289:
+^Idump_stack();^I$
WARNING: Unnecessary ftrace-like logging - prefer using ftrace — 3 instances

total: 18 errors, 5 warnings, 0 checks, 153 lines checked
Commit 414a5f9 ("ucsi ccg role switch issue"):
ERROR: Missing Signed-off-by: line(s)
WARNING: Missing commit description - Add an appropriate one
ERROR: code indent should use tabs where possible — 2 instances
WARNING: please, no spaces at the start of a line — 2 instances

total: 3 errors, 3 warnings, 1 checks, 140 lines checked
Fix:
Add Signed-off-by to all three commits:
git rebase -i HEAD~3
# Mark commits 2, 3, 4 as 'edit'
git commit --amend -s --no-edit
git rebase --continue
# Repeat for each commit
Fix spacing errors in commit be4735a:

Add space after commas: pr_err("%s\n",__func__) → pr_err("%s\n", __func__)

Remove trailing space before ): enable ) → enable)

Remove trailing whitespace on line 2289 of drivers/usb/typec/class.c

Fix indentation in commit 414a5f9:

Replace leading spaces with tabs in drivers/usb/typec/ucsi/ucsi_ccg.c:1995

Wrap long lines in commit a3339f9:

Break lines at 100 characters or use shorter debug messages

Add commit descriptions to all three debug commits explaining the purpose of the debug logging
Reproduce locally:
./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git HEAD~3..HEAD
❌ check-patch-compliance

Root cause: All four commits lack the mandatory subject-line prefix required by the checker.

Failure details:
Checking commit: arm64: dts: qcom: shikra: Rework USB SS endpoint wiring
Commit summary does not start with a required prefix

Checking commit: debug logs usb
Commit summary does not start with a required prefix

Checking commit: debug logs ucsi orientation issue
Commit summary does not start with a required prefix

Checking commit: ucsi ccg role switch issue
Commit summary does not start with a required prefix
Fix:

The check-patch-compliance checker requires one of these prefixes: FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:.

Since these appear to be debug/work-in-progress commits:

If these are temporary debug commits not intended for upstream:

Use QCLINUX: prefix (though this will still fail check-patch-compliance — known limitation)

Or use PENDING: prefix (also fails the checker)

Note: Debug commits with vendor-only prefixes are not accepted by this checker

If these should be proper commits:

Commit 1: Add QCLINUX: prefix (DTS change for Shikra board)

Commits 2-4: These debug logging commits should likely be removed before merge or squashed into a proper debugging patch with appropriate prefix

Recommended action: Remove or squash commits 2-4 as they appear to be temporary debug instrumentation not suitable for the main branch.
git rebase -i HEAD~4
# Mark commits 2, 3, 4 as 'drop' or 'fixup' into commit 1
# Or reword commit 1 to: "QCLINUX: arm64: dts: qcom: shikra: Rework USB SS endpoint wiring"
❌ tag-check

Root cause: All four commits are missing the mandatory subject-line prefix tag.

Failure details:

Assuming the target branch is not qcom-next or qcom-next-staging, every commit must start with one of: FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, WORKAROUND:.

All four commits currently lack any prefix:

arm64: dts: qcom: shikra: Rework USB SS endpoint wiring

debug logs usb

debug logs ucsi orientation issue

ucsi ccg role switch issue

Fix:
git rebase -i HEAD~4
# Mark all commits as 'reword'
# Change subjects to:
# 1. "QCLINUX: arm64: dts: qcom: shikra: Rework USB SS endpoint wiring"
# 2-4: Remove these debug commits or prefix with "PENDING:" if keeping
Note: If the target branch is qcom-next or qcom-next-staging, this check does not apply. However, based on the presence of debug commits, this appears to be a development/testing branch where prefixes would be required.

Verdict

❌ 4 blockers must be fixed before merge:

Critical: All three debug commits (2/4, 3/4, 4/4) are missing Signed-off-by: trailers — this is a hard blocker

Critical: Commit 3/4 has 18 checkpatch errors (spacing, formatting) that must be fixed

Critical: All four commits lack required subject-line prefixes for check-patch-compliance

Recommended: The three debug logging commits (2/4, 3/4, 4/4) appear to be temporary instrumentation and should likely be removed or squashed before merging to a production branch

Recommended workflow:

Remove commits 2-4 (debug logging) as they appear to be temporary debugging code

Add QCLINUX: prefix to commit 1 subject

Ensure commit 1 has proper Signed-off-by: trailer

Re-run checkers to verify

qswat-orbit-external · 2026-11-02T10:08:00Z

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

qlijarvis · 2026-11-02T11:28:37Z

PR #1374 — validate-patch

PR: #1374

Verdict	Issues	Detailed Report
❌	0	Full report

Final Summary

Lore link present: No — no lore.kernel.org links found in any of the 4 commits
Lore link matches PR commits: N/A — no lore links to compare against
Upstream patch status: N/A — no upstream references; commits appear to be debug/test code not intended for upstream
PR present in qcom-next/topics: Fail - 1/4 commit(s) are missing from both qcom-next and topics

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1374
Upstream commit: N/A — no lore.kernel.org links found
Verdict: ❌ FAIL

Commit Message

Commit Check Status Note

1/4 Subject matches upstream ❌ No lore link to compare against

1/4 Body preserves rationale ⚠️ Minimal description; no Fixes tag

1/4 Authorship preserved ❌ No vendor prefix (UPSTREAM:/FROMLIST:/BACKPORT:/QCLINUX:)

1/4 Backport note N/A Not applicable without lore link

2/4 Subject ❌ "debug logs usb" — not a proper commit subject

2/4 Body ❌ Empty commit message body

2/4 Authorship preserved ❌ No vendor prefix

3/4 Subject ❌ "debug logs ucsi orientation issue" — not a proper commit subject

3/4 Body ❌ Empty commit message body

3/4 Authorship preserved ❌ No vendor prefix

4/4 Subject ❌ "ucsi ccg role switch issue" — not a proper commit subject

4/4 Body ❌ Empty commit message body

4/4 Authorship preserved ❌ No vendor prefix

Diff

Commit File Status Notes

1/4 arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts ❌ Contains test string "TEst1" in model property

1/4 arch/arm64/boot/dts/qcom/shikra.dtsi ⚠️ USB endpoint rewiring; commented-out line present

2/4 drivers/usb/dwc3/core.c ❌ Debug macro redefinitions (#undef dev_dbg / #define dev_dbg dev_err)

2/4 drivers/usb/dwc3/dwc3-qcom.c ❌ Debug macro redefinitions and verbose logging

2/4 drivers/usb/dwc3/gadget.c ❌ Debug macro redefinitions

3/4 drivers/phy/qualcomm/phy-qcom-qmp-usbc.c ❌ dump_stack() and pr_err debug calls

3/4 drivers/usb/dwc3/dwc3-qcom.c ❌ dump_stack() and pr_err debug calls

3/4 drivers/usb/typec/class.c ❌ dump_stack() and pr_err debug calls

3/4 drivers/usb/typec/ucsi/ucsi.c ❌ pr_err debug calls throughout

3/4 drivers/usb/typec/ucsi/ucsi_ccg.c ❌ Syntax errors: duump_stack() (typo), missing semicolon after pr_err

3/4 drivers/usb/typec/ucsi/ucsi_glink.c ❌ dump_stack() and pr_err debug calls

4/4 arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts ❌ Test string "TEst2" in model property

4/4 drivers/clk/qcom/gcc-shikra.c ⚠️ GDSC power state change (PWRSTS_OFF_ON → PWRSTS_RET_ON)

4/4 drivers/usb/typec/ucsi/ucsi_ccg.c ⚠️ Adds GPIO orientation support; fixes syntax errors from commit 3/4

Issues

Critical Issues:

No lore.kernel.org links — All 4 commits lack any upstream reference (Link:, Patch-mainline:, or similar tags). Per the validate-patch skill, this is an immediate FAIL.

Missing vendor prefixes — None of the commits have the required prefix:

UPSTREAM: for merged patches

FROMLIST: for posted but not-yet-merged patches

BACKPORT: for adapted upstream patches

QCLINUX: for vendor-only changes

PENDING: for work-in-progress

WORKAROUND: for temporary fixes

Debug/test code in production commits:

Commit 2/4: Redefines dev_dbg, dev_info, pr_debug to dev_err/pr_err — forces all debug messages to error level

Commits 2/4, 3/4: Multiple dump_stack() calls in hot paths

Commits 1/4, 4/4: Test strings "TEst1" and "TEst2" in device tree model property

Commit 3/4: Syntax errors — duump_stack() typo and missing semicolon after pr_err(__func__)

Empty commit message bodies — Commits 2/4, 3/4, 4/4 have no description, rationale, or context.

Non-descriptive subjects:

"debug logs usb"

"debug logs ucsi orientation issue"

"ucsi ccg role switch issue"

These do not follow kernel commit message conventions (imperative mood, subsystem prefix, clear action).

Commented-out code — Commit 1/4 leaves //remote-endpoint = <&usb_qmpphy_usb_ss_in>; in shikra.dtsi.

Logical Issues:

Commit 4/4 fixes syntax errors introduced by commit 3/4 — The typo duump_stack() and missing semicolon in commit 3/4 are corrected in commit 4/4. This indicates the series was not tested as a whole before submission.

GDSC power state change — Commit 4/4 changes USB GDSC from PWRSTS_OFF_ON to PWRSTS_RET_ON without explanation. This is a functional change that should be in a separate commit with proper justification.

Verdict

Do not merge. This PR contains debug/test code, syntax errors, missing commit metadata, and no upstream references. The commits must be reworked:

Remove debug commits — Commits 2/4 and 3/4 should not be in a production tree.

Remove test strings — "TEst1" and "TEst2" in device tree model properties.

Add vendor prefixes — Every commit must have a prefix indicating its upstream status.

Add lore links or mark as QCLINUX: — If these are vendor-only changes, use QCLINUX: prefix and document why they are not upstream. If they are based on upstream work, add Link: tags.

Write proper commit messages — Describe what the change does, why it's needed, and what problem it solves.

Fix commented-out code — Remove or document the commented line in commit 1/4.

Separate functional changes — The GDSC power state change in commit 4/4 should be a standalone commit with rationale.

Test the series — Ensure each commit builds and runs without syntax errors.

Final Summary

Lore link present: No — no lore.kernel.org links found in any of the 4 commits

Lore link matches PR commits: N/A — no lore links to compare against

Upstream patch status: N/A — no upstream references; commits appear to be debug/test code not intended for upstream

PR present in qcom-next/topics: Fail — per integration_presence_report.md: 1/4 commit missing, 3/4 partial. Overall status: FAIL. Final summary: "PR present in qcom-next/topics: Fail - 1/4 commit(s) are missing from both qcom-next and topics"

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 17bbb4b37bbc4fc5827b4667445a0c43967c0f48
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final

1/4 [PATCH 1/4] arm64: dts: qcom: shikra: Rework USB SS endpoint wiring partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial

2/4 [PATCH 2/4] debug logs usb partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial

3/4 [PATCH 3/4] debug logs ucsi orientation issue missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

4/4 [PATCH 4/4] ucsi ccg role switch issue partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial

Final Status

overall_status: FAIL
present_commits: 0/4
partial_commits: 3/4
missing_commits: 1/4
topics_checked_for_commits: 4/4
final_summary: PR present in qcom-next/topics: Fail - 1/4 commit(s) are missing from both qcom-next and topics

qlijarvis · 2026-11-02T11:28:39Z

PR #1374 — checker-log-analyzer

PR: #1374
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/41426473688

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	4 commits: 1 pass, 3 fail (23 errors, 12 warnings, 1 check)
dt-binding-check	⏭️	No DT binding changes
dtb-check	✅	Test passed
sparse-check	✅	Passed
check-uapi-headers	✅	No UAPI changes
check-patch-compliance	❌	4 commits missing required prefix
tag-check	❌	4 commits missing required prefix (target branch unknown, assuming not qcom-next)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1374 - USB SS endpoint wiring and debug logs
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/41426473688

Checker Result Summary

checkpatch ❌ 4 commits: 1 pass, 3 fail (23 errors, 12 warnings, 1 check)

dt-binding-check ⏭️ No DT binding changes

dtb-check ✅ Test passed

sparse-check ✅ Passed

check-uapi-headers ✅ No UAPI changes

check-patch-compliance ❌ 4 commits missing required prefix

tag-check ❌ 4 commits missing required prefix (target branch unknown, assuming not qcom-next)

❌ checkpatch

Root cause: Three debug commits contain coding style violations (missing spaces after commas, trailing whitespace, unnecessary ftrace-like logging, missing commit descriptions, missing Signed-off-by lines, and improper indentation).

Failure details:

Commit 1/4: arm64: dts: qcom: shikra: Rework USB SS endpoint wiring ✅ PASS

Commit 2/4: debug logs usb ❌ FAIL
WARNING: Missing commit description - Add an appropriate one
WARNING: line length of 103 exceeds 100 columns
#58: FILE: drivers/usb/dwc3/core.c:2654:
+		dev_info(dwc->dev, "dwc3-pmdbg: runtime_suspend: suspend_common failed ret=%d\n", ret);
WARNING: line length of 109 exceeds 100 columns
#165: FILE: drivers/usb/dwc3/dwc3-qcom.c:830:
+		dev_info(dev, "dwc3-pmdbg: qcom_runtime_suspend: dwc3_runtime_suspend failed ret=%d\n", ret);
ERROR: Missing Signed-off-by: line(s)
total: 1 errors, 3 warnings, 0 checks, 215 lines checked
Commit 3/4: debug logs ucsi orientation issue ❌ FAIL
WARNING: Missing commit description - Add an appropriate one
ERROR: space required after that ',' (ctx:VxV)
#24: FILE: drivers/phy/qualcomm/phy-qcom-qmp-usbc.c:1754:
+	pr_err("%s orientation:%d\n",__func__, orientation);
ERROR: space required after that ',' (ctx:VxV) [multiple instances]
ERROR: space prohibited before that close parenthesis ')'
#42: FILE: drivers/usb/dwc3/dwc3-qcom.c:126:
+	pr_err("%s enable:%d\n",__func__, enable );
ERROR: trailing whitespace
#72: FILE: drivers/usb/typec/class.c:2289:
+^Idump_stack();^I$
ERROR: spaces required around that ':' (ctx:VxE)
#155: FILE: drivers/usb/typec/ucsi/ucsi_ccg.c:1846:
+	pr_err("%s\n",__func__):
WARNING: Unnecessary ftrace-like logging - prefer using ftrace [multiple instances]
ERROR: Missing Signed-off-by: line(s)
total: 18 errors, 5 warnings, 0 checks, 153 lines checked
Commit 4/4: ucsi ccg role switch issue ❌ FAIL
WARNING: Missing commit description - Add an appropriate one
ERROR: space required after that ',' (ctx:VxV)
#100: FILE: drivers/usb/typec/ucsi/ucsi_ccg.c:1860:
+	pr_err("%s\n",__func__);
WARNING: Unnecessary ftrace-like logging - prefer using ftrace
CHECK: Alignment should match open parenthesis
#134: FILE: drivers/usb/typec/ucsi/ucsi_ccg.c:1982:
ERROR: code indent should use tabs where possible
#145: FILE: drivers/usb/typec/ucsi/ucsi_ccg.c:1994:
WARNING: please, no spaces at the start of a line
ERROR: Missing Signed-off-by: line(s)
total: 4 errors, 4 warnings, 1 checks, 150 lines checked
Fix:

For each failing commit:
Add Signed-off-by line:
git rebase -i <base_sha>   # mark commit as 'edit'
git commit --amend -s --no-edit
git rebase --continue
Fix spacing issues:

Add space after commas: pr_err("%s\n",__func__) → pr_err("%s\n", __func__)

Remove trailing spaces: sed -i 's/[[:space:]]*$//' <file>

Fix indentation: Replace leading spaces with tabs

Remove space before ): __func__ ) → __func__)
Add commit descriptions:
git rebase -i <base_sha>   # mark commit as 'reword'
# Add a proper commit body explaining the debug changes
Consider removing debug commits: These appear to be temporary debug logs (pr_err, dev_info with "pmdbg" prefix) that should not be in production code. Consider:

Removing these commits entirely before merge

Converting to proper tracepoints instead of ftrace-like logging

Using dynamic debug (pr_debug) instead of pr_err
Reproduce locally:
./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 58b1e624b961920b9e3924f17301dc4dd0ccc405..9e51438cd4da9fc9c0396ac16c1f36341fcbfc42
❌ check-patch-compliance

Root cause: All 4 commits lack required subject-line prefixes (FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT:).

Failure details:
Checking commit: arm64: dts: qcom: shikra: Rework USB SS endpoint wiring
Commit summary does not start with a required prefix

Checking commit: debug logs usb
Commit summary does not start with a required prefix

Checking commit: debug logs ucsi orientation issue
Commit summary does not start with a required prefix

Checking commit: ucsi ccg role switch issue
Commit summary does not start with a required prefix
Fix:

Add appropriate prefix to each commit subject:
git rebase -i <base_sha>   # mark each commit as 'reword'
Choose the correct prefix based on patch origin:

Commit Suggested Prefix Rationale

arm64: dts: qcom: shikra: Rework USB SS endpoint wiring QCLINUX: or PENDING: Appears to be vendor-specific DTS change

debug logs usb Should be removed Temporary debug code

debug logs ucsi orientation issue Should be removed Temporary debug code

ucsi ccg role switch issue Should be removed Temporary debug code

Note: If these are posted to lore.kernel.org, use FROMLIST: and add Link: trailer. If vendor-only, use QCLINUX: (but note that check-patch-compliance will still fail for QCLINUX: — this is a known checker limitation).

Reproduce locally:
# The checker script is in kernel-checkers repo
bash ../kernel-checkers/check-patch-compliance.sh --kernel-src . --base <base_sha> --head <head_sha>
❌ tag-check

Root cause: All 4 commits lack mandatory subject-line prefix tags required for branches other than qcom-next / qcom-next-staging.

Failure details:

The target branch for this PR could not be determined from available data (network unavailable). However, assuming the target is not qcom-next or qcom-next-staging, all commits must start with one of these prefixes:

FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

Current commit subjects (all missing prefix):

arm64: dts: qcom: shikra: Rework USB SS endpoint wiring

debug logs usb

debug logs ucsi orientation issue

ucsi ccg role switch issue

Fix:

Same as check-patch-compliance fix above — add appropriate prefix to each commit subject.

If target branch is qcom-next or qcom-next-staging: This check does not apply; mark as N/A.

Verdict

🚫 BLOCKERS — Do NOT merge as-is

Critical issues:

3 debug commits should be removed entirely — these contain temporary debug logging (pr_err, dev_info with "pmdbg" prefix) that should not be in production code

All 4 commits missing Signed-off-by lines — mandatory for kernel contributions

All 4 commits missing required subject prefix — violates branch policy (unless targeting qcom-next/qcom-next-staging)

23 coding style errors across 3 commits — spacing, indentation, trailing whitespace

Recommended action:

Option A (Preferred): Clean up the PR

Remove commits 2, 3, 4 (debug logs) entirely

Keep only commit 1 (arm64: dts: qcom: shikra: Rework USB SS endpoint wiring)

Add appropriate prefix to commit 1 subject (e.g., QCLINUX: or PENDING:)

Add Signed-off-by line to commit 1

Force-push cleaned branch

Option B: Fix all issues

Add Signed-off-by to all 4 commits

Fix all 23 coding style errors

Add commit descriptions to commits 2, 3, 4

Add appropriate prefix to all 4 commit subjects

Convert debug logs to proper tracepoints or dynamic debug

Force-push fixed branch

Option A is strongly recommended — debug commits should not be in the production tree.

qswat-orbit-external · 2026-11-02T16:43:07Z

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

qlijarvis · 2026-11-02T17:39:19Z

PR #1374 — validate-patch

PR: #1374

Verdict	Issues	Detailed Report
❌	0	Full report

Final Summary

Lore link present: No — no lore.kernel.org links found in any of the 3 commits. No commit prefix indicating origin (UPSTREAM:/FROMLIST:/QCLINUX:/etc.).
Lore link matches PR commits: N/A — no lore links to compare against. Cannot validate diff faithfulness without upstream source.
Upstream patch status: N/A — no upstream source identified. Commits appear to be local debug/test code not intended for upstream submission.
PR present in qcom-next/topics: Fail - 1/3 commit(s) are missing from both qcom-next and topics

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1374
Upstream: (none found)
Verdict: ❌ FAIL

Reason

No lore.kernel.org link was found in any of the 3 commits in this PR. All commits lack:

Commit message prefix (UPSTREAM:, FROMLIST:, BACKPORT:, QCLINUX:, etc.)

Commit message body explaining the rationale for changes

Signed-off-by trailers

Link: tags to upstream sources

This skill validates patches against lore.kernel.org sources. Without lore links or proper commit prefixes, validation cannot proceed.

Commit Analysis

Commit 1/3: debug logs usb

Author: Akash Kumar akakum@qti.qualcomm.com

Changes: Redefines dev_dbg/dev_info/pr_debug to dev_err/pr_err in dwc3 core, adds debug logging to runtime PM paths

Issues:

No commit message body

No Signed-off-by trailer

No commit prefix indicating origin (should be QCLINUX: or PENDING: for debug code)

Debug macro redefinition (#undef dev_dbg / #define dev_dbg dev_err) is not acceptable for production code

Commit 2/3: debug logs ucsi orientation issue

Author: Akash Kumar akakum@qti.qualcomm.com

Changes: Adds dump_stack() and pr_err debug statements to USB Type-C orientation handling

Issues:

No commit message body

No Signed-off-by trailer

No commit prefix

dump_stack() calls are debug instrumentation, not production code

Commit 3/3: ucsi ccg role switch issue

Author: Akash Kumar akakum@qti.qualcomm.com

Changes:

Changes device tree model string to "TEST3" (clearly a test marker)

Changes USB GDSC power states from PWRSTS_OFF_ON to PWRSTS_RET_ON

Adds 84 lines of new code to ucsi_ccg.c

Issues:

No commit message body explaining why GDSC power states are changed

No Signed-off-by trailer

No commit prefix

"TEST3" in device tree model string indicates this is test/debug code

Significant functional changes (GDSC power state, new ucsi_ccg code) without any explanation

Commit Message

Check Status Note

Subject matches upstream ❌ No upstream source to compare against

Body preserves rationale ❌ All commits have empty message bodies

Fixes tag present/correct ❌ No Fixes: tags present

Authorship preserved N/A No upstream source to verify against

Backport note (if applicable) N/A Not backports

Signed-off-by present ❌ All commits lack Signed-off-by trailers

Commit prefix present ❌ No prefix (UPSTREAM:/FROMLIST:/QCLINUX:/etc.) on any commit

Diff

File Status Notes

drivers/usb/dwc3/core.c ❌ Debug macro redefinition not acceptable for production

drivers/usb/dwc3/dwc3-qcom.c ❌ Debug logging without explanation

drivers/usb/dwc3/gadget.c ❌ Debug logging without explanation

drivers/phy/qualcomm/phy-qcom-qmp-usbc.c ❌ dump_stack() is debug instrumentation

drivers/usb/typec/class.c ❌ Debug logging without explanation

drivers/usb/typec/ucsi/ucsi.c ❌ Debug logging without explanation

drivers/usb/typec/ucsi/ucsi_ccg.c ❌ 84 lines of new code without explanation

drivers/usb/typec/ucsi/ucsi_glink.c ❌ Debug logging without explanation

arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts ❌ "TEST3" marker in model string

drivers/clk/qcom/gcc-shikra.c ❌ GDSC power state change without explanation

Issues

Critical Issues:

No commit message bodies: All three commits have only a subject line with no explanation of what problem is being solved, why the change is needed, or what the expected behavior is.

No Signed-off-by trailers: All commits violate the Developer Certificate of Origin requirement. Every kernel commit must have at least one Signed-off-by: line from the author.

No commit prefixes: Commits lack the required prefix indicating their origin:

If these are vendor-only debug changes → should use QCLINUX: or PENDING: prefix

If based on upstream patches → should use UPSTREAM:, FROMLIST:, or BACKPORT: with Link: tags

If temporary workarounds → should use WORKAROUND: prefix

Debug code in production tree:

Commit 1 redefines standard kernel logging macros (dev_dbg → dev_err) globally, which will cause all debug messages to be printed as errors

Commit 2 adds dump_stack() calls that will spam the kernel log

Commit 3 adds "TEST3" to the device tree model string

Unexplained functional changes: Commit 3 changes USB GDSC power states from PWRSTS_OFF_ON to PWRSTS_RET_ON without any explanation of why this is needed or what problem it solves.

Integration presence failure: According to integration_presence_report.md:

0/3 commits are fully present in qcom-next or topics

2/3 commits show partial evidence (subject or partial tree match)

1/3 commits are completely missing

Overall status: FAIL

Recommendation

DO NOT MERGE. This PR contains debug/test code that is not suitable for any production branch.

Required actions:

If these are temporary debug commits for local testing:

Do not submit as a PR to the main repository

Keep in a local development branch

Revert before submitting any production code

If any of these changes are intended for production:

Write proper commit messages with:

Problem statement (what bug/issue is being fixed)

Root cause analysis

Solution explanation

Testing performed

Add Signed-off-by: trailers

Add appropriate commit prefix (QCLINUX:, UPSTREAM:, FROMLIST:, etc.)

Remove all debug instrumentation (macro redefinitions, dump_stack(), "TEST3" markers)

Split functional changes (GDSC power state) from debug changes

If based on upstream work, add Link: tags to lore.kernel.org

For the GDSC power state change (commit 3):

Explain why PWRSTS_RET_ON is needed instead of PWRSTS_OFF_ON

Document any hardware errata or power management requirements

Reference any related upstream discussions or patches

Final Summary

Lore link present: No — no lore.kernel.org links found in any of the 3 commits. No commit prefix indicating origin (UPSTREAM:/FROMLIST:/QCLINUX:/etc.).

Lore link matches PR commits: N/A — no lore links to compare against. Cannot validate diff faithfulness without upstream source.

Upstream patch status: N/A — no upstream source identified. Commits appear to be local debug/test code not intended for upstream submission.

PR present in qcom-next/topics: Fail — per integration_presence_report.md: 0/3 commits fully present, 2/3 partial matches, 1/3 completely missing. Overall status: FAIL. These commits do not appear to be part of the standard integration workflow.

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 17bbb4b37bbc4fc5827b4667445a0c43967c0f48
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final

1/3 [PATCH 1/3] debug logs usb partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial

2/3 [PATCH 2/3] debug logs ucsi orientation issue missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

3/3 [PATCH 3/3] ucsi ccg role switch issue partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial

Final Status

overall_status: FAIL
present_commits: 0/3
partial_commits: 2/3
missing_commits: 1/3
topics_checked_for_commits: 3/3
final_summary: PR present in qcom-next/topics: Fail - 1/3 commit(s) are missing from both qcom-next and topics

qlijarvis · 2026-11-02T17:39:21Z

PR #1374 — checker-log-analyzer

PR: #1374
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/41484344529

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	26 errors, 15 warnings, 1 check across 3 commits
dt-binding-check	⏭️	No DT binding changes
dtb-check	✅	Test passed
sparse-check	✅	Passed
check-uapi-headers	✅	No UAPI changes
check-patch-compliance	❌	All 3 commits missing required prefix
tag-check	❌	All 3 commits missing required subject prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1374 - USB debug logs and UCSI CCG role switch issue
Target branch: qcom-6.18.y
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/41484344529

Checker Result Summary

checkpatch ❌ 26 errors, 15 warnings, 1 check across 3 commits

dt-binding-check ⏭️ No DT binding changes

dtb-check ✅ Test passed

sparse-check ✅ Passed

check-uapi-headers ✅ No UAPI changes

check-patch-compliance ❌ All 3 commits missing required prefix

tag-check ❌ All 3 commits missing required subject prefix

❌ checkpatch

Root cause: Multiple coding style violations across all three commits: missing Signed-off-by, missing commit descriptions, spacing errors, long lines, and unnecessary ftrace-like logging.

Failure details:

Commit 1: 43e8d4306181 ("debug logs usb")
WARNING: Missing commit description - Add an appropriate one
WARNING: line length of 103 exceeds 100 columns
#58: FILE: drivers/usb/dwc3/core.c:2654:
+		dev_info(dwc->dev, "dwc3-pmdbg: runtime_suspend: suspend_common failed ret=%d\n", ret);

WARNING: line length of 109 exceeds 100 columns
#165: FILE: drivers/usb/dwc3/dwc3-qcom.c:830:
+		dev_info(dev, "dwc3-pmdbg: qcom_runtime_suspend: dwc3_runtime_suspend failed ret=%d\n", ret);

ERROR: Missing Signed-off-by: line(s)
total: 1 errors, 3 warnings, 0 checks, 215 lines checked
Commit 2: 76c1825692ba ("debug logs ucsi orientation issue")
WARNING: Missing commit description - Add an appropriate one
ERROR: space required after that ',' (ctx:VxV)
#29: FILE: drivers/phy/qualcomm/phy-qcom-qmp-usbc.c:1759:
+	pr_err("%s orientation:%d end\n",__func__, orientation);

ERROR: space required after that ',' (ctx:VxV)
#41: FILE: drivers/usb/dwc3/dwc3-qcom.c:126:

ERROR: space prohibited before that close parenthesis ')'
#41: FILE: drivers/usb/dwc3/dwc3-qcom.c:126:

ERROR: trailing whitespace
#71: FILE: drivers/usb/typec/class.c:2289:

WARNING: Unnecessary ftrace-like logging - prefer using ftrace
(multiple instances in ucsi.c, ucsi_ccg.c, ucsi_glink.c)

ERROR: Missing Signed-off-by: line(s)
total: 17 errors, 5 warnings, 0 checks, 152 lines checked
Commit 3: 6166745e5141 ("ucsi ccg role switch issue")
WARNING: Missing commit description - Add an appropriate one
ERROR: space required after that ',' (ctx:VxV)
(multiple instances in ucsi_ccg.c)

WARNING: Unnecessary ftrace-like logging - prefer using ftrace
(multiple instances)

CHECK: Alignment should match open parenthesis
#139: FILE: drivers/usb/typec/ucsi/ucsi_ccg.c:1987:

ERROR: code indent should use tabs where possible
#151: FILE: drivers/usb/typec/ucsi/ucsi_ccg.c:2000:

WARNING: please, no spaces at the start of a line
#151: FILE: drivers/usb/typec/ucsi/ucsi_ccg.c:2000:

ERROR: Missing Signed-off-by: line(s)
total: 8 errors, 7 warnings, 1 checks, 156 lines checked
Fix:

For each commit:

Add commit description — Explain what the debug logs are for and why they're needed

Add Signed-off-by — git commit --amend -s for each commit

Fix spacing errors:

Add space after commas: pr_err("%s orientation:%d\n", __func__, orientation);

Remove space before close parenthesis

Remove trailing whitespace: sed -i 's/[[:space:]]*$//' <file>

Wrap long lines — Break lines at 100 characters

Fix indentation — Use tabs, not spaces (lines 2000-2001 in ucsi_ccg.c)

Consider removing ftrace-like logging — The dev_info calls with function entry/exit messages should use ftrace instead, or justify why they're needed for debugging

Reproduce locally:
./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git HEAD~3..HEAD
Fix workflow:
git rebase -i HEAD~3
# Mark each commit as 'edit'
# For each commit:
#   - Fix the code issues
#   - Add commit description
#   - git add <files>
#   - git commit --amend -s
#   - git rebase --continue
❌ check-patch-compliance

Root cause: All three commits lack the required subject-line prefix (FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT:).

Failure details:
Checking commit: debug logs usb
Commit summary does not start with a required prefix

Checking commit: debug logs ucsi orientation issue
Commit summary does not start with a required prefix

Checking commit: ucsi ccg role switch issue
Commit summary does not start with a required prefix
Fix:

Since these appear to be debug/development commits with no upstream equivalent, the appropriate actions are:
If these are temporary debug commits — Add PENDING: prefix (note: this will still fail check-patch-compliance, which is a known limitation for vendor-only commits):
PENDING: debug logs usb
PENDING: debug logs ucsi orientation issue
PENDING: ucsi ccg role switch issue
If these are vendor-specific changes — Add QCLINUX: prefix (note: this will also fail check-patch-compliance):
QCLINUX: debug logs usb
QCLINUX: debug logs ucsi orientation issue
QCLINUX: ucsi ccg role switch issue
If these are based on upstream patches — Add FROMLIST: or UPSTREAM: prefix and include a Link: tag pointing to the lore.kernel.org URL.
Reproduce locally:
# Check each commit subject
git log --oneline HEAD~3..HEAD
Fix command:
git rebase -i HEAD~3
# Mark each commit as 'reword'
# Change subject to include appropriate prefix
❌ tag-check

Root cause: Target branch is qcom-6.18.y (not qcom-next or qcom-next-staging), which requires all commits to have a subject-line prefix. All three commits are missing this mandatory prefix.

Failure details:

Commit 43e8d4306181 ("debug logs usb"): subject line does not start with a required prefix

Commit 76c1825692ba ("debug logs ucsi orientation issue"): subject line does not start with a required prefix

Commit 6166745e5141 ("ucsi ccg role switch issue"): subject line does not start with a required prefix

All branches except qcom-next and qcom-next-staging require one of:
FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

Fix:

Choose the appropriate prefix based on the patch origin:

Prefix When to use

FROMLIST: Posted to lore.kernel.org but not yet merged

FROMGIT: Taken from a maintainer git tree

UPSTREAM: Merged into Linus's mainline tree

BACKPORT: Upstream patch backported with modifications

QCLINUX: Vendor-only change with no upstream equivalent

PENDING: Work-in-progress, not yet posted upstream

WORKAROUND: Temporary fix not suitable for upstream

For these debug commits, the most appropriate prefix is likely PENDING: or QCLINUX:.

Fix command:
git rebase -i HEAD~3
# Mark each commit as 'reword'
# Add prefix to each subject, e.g.:
#   PENDING: debug logs usb
#   PENDING: debug logs ucsi orientation issue
#   PENDING: ucsi ccg role switch issue
Verdict

3 blockers must be fixed before merge:

checkpatch failures — 26 errors including missing Signed-off-by on all 3 commits, spacing errors, long lines, and indentation issues

check-patch-compliance failures — All 3 commits missing required subject prefix

tag-check failures — All 3 commits missing mandatory subject prefix for qcom-6.18.y branch

Recommended action:

Add appropriate subject prefix (PENDING: or QCLINUX:) to all commits

Add commit descriptions explaining the purpose of the debug logs

Add Signed-off-by: to all commits

Fix all spacing, indentation, and line length issues

Consider whether the ftrace-like logging is necessary or if ftrace should be used instead

akakum-qualcomm requested review from a team, aiquny, Amit Kucheria (idlethread) and yijiyang November 1, 2026 18:03

akakum-qualcomm force-pushed the akash/shikra-usb-role-switch-fix branch from 414a5f9 to 9852b95 Compare November 2, 2026 10:07

akakum-qualcomm added 3 commits November 2, 2026 21:56

debug logs usb

43e8d43

debug logs ucsi orientation issue

76c1825

ucsi ccg role switch issue

6166745

akakum-qualcomm force-pushed the akash/shikra-usb-role-switch-fix branch from 9852b95 to 6166745 Compare November 2, 2026 16:42

Conversation

akakum-qualcomm commented Nov 1, 2026

Uh oh!

qswat-orbit-external Bot commented Nov 1, 2026

Uh oh!

qswat-orbit-external Bot commented Nov 1, 2026

Uh oh!

qswat-orbit-external Bot commented Nov 1, 2026

Uh oh!

qswat-orbit-external Bot commented Nov 1, 2026

Uh oh!

qswat-orbit-external Bot commented Nov 2, 2026

Uh oh!

qlijarvis commented Nov 2, 2026

PR #1374 — validate-patch

Final Summary

🔍 Patch Validation

Commit Message

Diff

Issues

Verdict

Final Summary

Deterministic Integration Presence

Integration Presence Report

Final Status

Uh oh!

qlijarvis commented Nov 2, 2026

PR #1374 — checker-log-analyzer

🤖 CI Checker Analysis (checker-log-analyzer)

❌ checkpatch

❌ check-patch-compliance

❌ tag-check

Verdict

Uh oh!

qswat-orbit-external Bot commented Nov 2, 2026

Uh oh!

qlijarvis commented Nov 2, 2026

PR #1374 — validate-patch

Final Summary

🔍 Patch Validation

Commit Message

Diff

Issues

Verdict

Final Summary

Deterministic Integration Presence

Integration Presence Report

Final Status

Uh oh!

qlijarvis commented Nov 2, 2026

PR #1374 — checker-log-analyzer

🤖 CI Checker Analysis (checker-log-analyzer)

❌ checkpatch

❌ check-patch-compliance

❌ tag-check

Verdict

Uh oh!

qswat-orbit-external Bot commented Nov 2, 2026

Uh oh!

qlijarvis commented Nov 2, 2026

PR #1374 — validate-patch

Final Summary

🔍 Patch Validation

Reason

Commit Analysis

Commit Message

Diff

Issues

Recommendation

Final Summary

Deterministic Integration Presence

Integration Presence Report

Final Status

Uh oh!

qlijarvis commented Nov 2, 2026

PR #1374 — checker-log-analyzer

🤖 CI Checker Analysis (checker-log-analyzer)

❌ checkpatch

❌ check-patch-compliance

❌ tag-check