Skip to content

Prop Bleeding to HTML attribs. #75

Open
Open
Prop Bleeding to HTML attribs.#75
Labels
bugSomething isn't working

Description

@t-schemmer
t-schemmer
opened on Jul 2, 2020

In some cases when providing props to components, there is some non-compliant html attribute bleeding.
e.g.
display is passed to the html node because it's not destructured from the props before being passed to children.

Perhaps making use of shouldForwardProp will remedy this, and keep the HTML compliant.

Activity

  1. t-schemmer
    added
    questionFurther information is requested
    status: needs triageThese issues haven't been looked at yet by a maintainer.
    on Jul 2, 2020

  2. winkerVSbecks commented on Jul 2, 2020

    @winkerVSbecks
    winkerVSbecks
    on Jul 2, 2020
    Contributor

    Thank you. Was waiting for that PR to be merged.

  3. tylervipond
    added
    enhancementNew feature or request
    bugSomething isn't working
    and removed
    status: needs triageThese issues haven't been looked at yet by a maintainer.
    enhancementNew feature or request
    questionFurther information is requested
    on Jul 16, 2020

  4. tylervipond commented on Jul 16, 2020

    @tylervipond
    tylervipond
    on Jul 16, 2020

    changing this into a bug at this point, as this is fixable, and should be low risk to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions