feat(billing): move plan writes to AdminService and add ListAllPlans - #1828
feat(billing): move plan writes to AdminService and add ListAllPlans#1828rohilsurana wants to merge 0 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1461790 to
0c9d968
Compare
Coverage Report for CI Build 30618820279Coverage increased (+0.1%) to 47.805%Details
Uncovered Changes
Coverage Regressions276 previously-covered lines in 3 files lost coverage.
Coverage Stats
💛 - Coveralls |
0c9d968 to
35df3f1
Compare
What
Wire the frontier side of the plan admin APIs from raystack/proton#496.
CreatePlanandUpdatePlantoAdminService(super user only). They were onFrontierServicebefore.ListAllPlansonAdminService. It lists every plan, including disabled ones. An empty state returns all plans; a set state filters to it.CreatePlannow carries the planstate.UpdatePlanis implemented (it returnedUnimplementedbefore) and does a full write of a plan's own fields (title, description, credits, trial days, state, metadata). A plan's products are still managed throughCreatePlan's upsert.ListPlansandGetPlanstay onFrontierServiceand are unchanged.How
ConnectHandlerserves both services, so the existingCreatePlanmethod now satisfiesAdminService.UpdatePlanandListAllPlansare added to it.AdminServiceplan RPCs behindIsSuperUser, and the oldFrontierServiceplan entries are removed. Any endpoint not listed is denied by default, so these entries are required.ListAllPlanspasses aplan.StateAllsentinel to the repository so an empty state lists plans in every state. The repository still defaults an empty state to active forListPlans, which lists active plans only.Depends on
Testing
UpdatePlanandListAllPlans. Existing plan handler and service tests pass.CreatePlanon the admin client.