chore!: remove plan_id from frontier ProductRequestBody - #495
Merged
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest Buf updates on your PR. Results from workflow Validate / validate (pull_request).
|
rohilsurana
marked this pull request as ready for review
July 30, 2026 08:39
AmanGIT07
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove
plan_idfromProductRequestBodyand reserve the field number (4) and the name, so it cannot be reused with a different meaning.ProductRequestBodyis shared byCreateProductandUpdateProduct.Why
Nothing links a product to a plan through this field in practice. Frontier links products to plans from the plan side:
UpsertPlanscreates the product and then callsAddPlan, after checking the product has an active price at the plan's interval.The request-body
plan_idwas a way around that check. Creating a product with aplan_idwrites the link straight to the database and skips the matching-price check, so you could link a product to a plan that has no valid price for its interval.UpdateProductalready ignored the field.Removing it makes plan membership owned solely by the plan side, and drops a dead field from
UpdateProductat the same time.Breaking change
This removes a public field. The number and name are reserved so the wire and JSON stay safe. Frontier's handler is updated to stop reading it in a matching PR.