Skip to content

[ALICE3] Please consider the following formatting changes to #16693 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alibuild wants to merge 1 commit into from
+2 −2
Closed

[ALICE3] Please consider the following formatting changes to #16693 #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ALICE3/DataModel/prefilterDilepton.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
#define ALICE3_DATAMODEL_PREFILTERDILEPTON_H_

// O2 includes
#include "Framework/AnalysisDataModel.h"
#include <Framework/AnalysisDataModel.h>

namespace o2::aod
{
Expand Down
2 changes: 1 addition & 1 deletion ALICE3/Tasks/alice3-prefilterdilepton.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.

Check failure on line 1 in ALICE3/Tasks/alice3-prefilterdilepton.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/workflow-file] 

Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)

Check failure on line 1 in ALICE3/Tasks/alice3-prefilterdilepton.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-task] 

Specify task name only when it cannot be derived from the struct name. Only append to the default name.
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
Expand Down Expand Up @@ -30,7 +30,7 @@
#include <Framework/runDataProcessing.h>
#include <MathUtils/Utils.h>

#include "Math/GenVector/VectorUtil.h"
#include <Math/GenVector/VectorUtil.h>
#include <Math/Vector4D.h>

#include <unordered_map>
Expand Down Expand Up @@ -78,7 +78,7 @@
float charge = pdgParticle->Charge() / 3.f; // Charge in units of |e|
if (std::abs(charge) >= 1.) {
registry.fill(HIST("Generated/Before/ParticlesEta"), mcParticle.eta());
if ((2.2 < mcParticle.eta() && mcParticle.eta() < 5.0) || (-3.4 < mcParticle.eta() && mcParticle.eta() < -2.3)) {

Check failure on line 81 in ALICE3/Tasks/alice3-prefilterdilepton.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
nParticlesFIT++;
}
}
Expand Down Expand Up @@ -124,11 +124,11 @@

Service<o2::framework::O2DatabasePDG> inspdg;

Configurable<float> ptMin{"pt-min", 0.f, "Lower limit in pT"};

Check failure on line 127 in ALICE3/Tasks/alice3-prefilterdilepton.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/configurable] 

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
Configurable<float> ptMax{"pt-max", 5.f, "Upper limit in pT"};

Check failure on line 128 in ALICE3/Tasks/alice3-prefilterdilepton.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/configurable] 

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
Configurable<float> etaMin{"eta-min", -5.f, "Lower limit in eta"};

Check failure on line 129 in ALICE3/Tasks/alice3-prefilterdilepton.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/configurable] 

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
Configurable<float> etaMax{"eta-max", 5.f, "Upper limit in eta"};

Check failure on line 130 in ALICE3/Tasks/alice3-prefilterdilepton.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/configurable] 

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
Configurable<float> maxMass{"max-mass", 5.f, "Upper limit in mass"};

Check failure on line 131 in ALICE3/Tasks/alice3-prefilterdilepton.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/configurable] 

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
Configurable<float> maxOp{"max-Op", 5.f, "Upper limit in opening angle"};
Configurable<float> nSigmaEleCutOuterTOF{"nSigmaEleCutOuterTOF", 3., "Electron inclusion in outer TOF"};
Configurable<float> nSigmaEleCutInnerTOF{"nSigmaEleCutInnerTOF", 3., "Electron inclusion in inner TOF"};
Expand Down Expand Up @@ -303,6 +303,6 @@
WorkflowSpec defineDataProcessing(ConfigContext const& cfgc)
{
return WorkflowSpec{
adaptAnalysisTask<Alice3DileptonEventCentSelection>(cfgc, TaskName{"alice3-dilepton-event-cent-selection"}),

Check failure on line 306 in ALICE3/Tasks/alice3-prefilterdilepton.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-task] 

Specified task name alice3-dilepton-event-cent-selection and the struct name Alice3DileptonEventCentSelection produce the same device name alice3-dilepton-event-cent-selection. TaskName is redundant.
adaptAnalysisTask<Alice3DileptonPrefilter>(cfgc, TaskName{"alice3-dilepton-prefilter"})};

Check failure on line 307 in ALICE3/Tasks/alice3-prefilterdilepton.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-task] 

Specified task name alice3-dilepton-prefilter and the struct name Alice3DileptonPrefilter produce the same device name alice3-dilepton-prefilter. TaskName is redundant.
}
Loading