Skip to content

fix: export notification list types#391

Merged
li-jia-nan merged 1 commit into
react-component:masterfrom
QDyanbing:antd-es-type-exports
May 14, 2026
Merged

fix: export notification list types#391
li-jia-nan merged 1 commit into
react-component:masterfrom
QDyanbing:antd-es-type-exports

Conversation

@QDyanbing
Copy link
Copy Markdown
Contributor

@QDyanbing QDyanbing commented May 14, 2026

Summary

  • Export NotificationListConfig from the package entry.
  • Export StackConfig from the package entry so downstream Vite builds can import from the esm entry instead of deep paths.

Validation

  • npm test
  • npm run compile
  • npm run lint (0 errors; existing hooks warnings remain)

Summary by CodeRabbit

  • 新增特性
    • 导出 NotificationListConfigStackConfig 类型,扩展公开的类型 API,为用户提供更完整的类型支持。

Review Change Stack

@vercel
Copy link
Copy Markdown

vercel Bot commented May 14, 2026

@QDyanbing is attempting to deploy a commit to the React Component Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bbf30a07-b2a5-47c9-b30e-ac20353a97bb

📥 Commits

Reviewing files that changed from the base of the PR and between 851fd85 and 4fecee6.

📒 Files selected for processing (1)
  • src/index.ts

概述

此 PR 在包的主入口文件 src/index.ts 中添加了 NotificationListConfigStackConfig 两个类型的导入和导出,使这些类型成为包的公开 API 的一部分。

变更

类型导出扩展

层级 / 文件 摘要
通知类型导入与导出
src/index.ts
src/index.ts 中导入 NotificationListConfigStackConfig 两个类型(第 8-9 行),并在模块的 export type { ... } 声明中新增这两个类型的导出条目(第 18-20 行)。

评估代码审查工作量

🎯 1 (简单) | ⏱️ ~3 分钟

可能相关的 PR

  • react-component/notification#388: 该 PR 同样修改 src/index.ts 以扩展包的公开导出,添加/重新导出与 NotificationList 相关的类型(包含 NotificationListConfigStackConfig),无运行时逻辑变更。

诗歌

🐰 小小兔子来贺喜,
类型纷纷出柜门,
NotificationListConfigStackConfig 齐,
API 更开放,
用户尽心悦!✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR标题准确反映了主要变更内容:导出notification相关的类型。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/index.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the config "prettier" to extend from. Please check that the name of the config is correct.

The config "prettier" was referenced from the config file in "/.eslintrc.js".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@QDyanbing QDyanbing marked this pull request as ready for review May 14, 2026 15:06
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the package entry point in src/index.ts to export NotificationListConfig and StackConfig types. The reviewer suggests expanding the public API by also exporting NotificationListProps and Placement, and recommends consolidating imports from the NotificationList module to avoid deep imports into the hooks directory.

Comment thread src/index.ts
Comment thread src/index.ts
@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.20%. Comparing base (851fd85) to head (4fecee6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #391   +/-   ##
=======================================
  Coverage   99.19%   99.20%           
=======================================
  Files          13       13           
  Lines        1372     1376    +4     
  Branches      182      182           
=======================================
+ Hits         1361     1365    +4     
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@li-jia-nan li-jia-nan merged commit 18f7aaa into react-component:master May 14, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants