fix: export notification list types#391
Conversation
|
@QDyanbing is attempting to deploy a commit to the React Component Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
概述此 PR 在包的主入口文件 变更类型导出扩展
评估代码审查工作量🎯 1 (简单) | ⏱️ ~3 分钟 可能相关的 PR
诗歌
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
src/index.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the config "prettier" to extend from. Please check that the name of the config is correct. The config "prettier" was referenced from the config file in "/.eslintrc.js". If you still have problems, please stop by https://eslint.org/chat/help to chat with the team. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the package entry point in src/index.ts to export NotificationListConfig and StackConfig types. The reviewer suggests expanding the public API by also exporting NotificationListProps and Placement, and recommends consolidating imports from the NotificationList module to avoid deep imports into the hooks directory.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #391 +/- ##
=======================================
Coverage 99.19% 99.20%
=======================================
Files 13 13
Lines 1372 1376 +4
Branches 182 182
=======================================
+ Hits 1361 1365 +4
Misses 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
NotificationListConfigfrom the package entry.StackConfigfrom the package entry so downstream Vite builds can import from the esm entry instead of deep paths.Validation
npm testnpm run compilenpm run lint(0 errors; existing hooks warnings remain)Summary by CodeRabbit
NotificationListConfig和StackConfig类型,扩展公开的类型 API,为用户提供更完整的类型支持。