Skip to content

Stop crashing on inconsistent clipping bookkeeping in ReactViewGroup.isViewClipped #57365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rozele wants to merge 1 commit into from
Closed

Stop crashing on inconsistent clipping bookkeeping in ReactViewGroup.isViewClipped #57365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions ...s/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,13 +756,11 @@ public open class ReactViewGroup public constructor(context: Context?) :
),
)
}
// fallback - should be transitioning or have no parent if the view was removed
if (parent == null || transitioning) {
return true
} else {
check(parent === this)
return false
}
// fallback - a view that is transitioning, has no parent, or is parented elsewhere is no longer
// a live child of `this`, so it is reported as clipped. Only a view still parented to `this`
// (and not transitioning) is not clipped. The missing-tag inconsistency is already surfaced as
// a soft exception above.
return transitioning || parent !== this
}

private fun indexOfChildInAllChildren(child: View): Int {
Expand Down
Loading