Cover oscompat with Stable API guards - #57960
Open
j-piasecki wants to merge 2 commits into
Open
Conversation
Differential Revision: D109847184
Summary: `oscompat` is an implementation detail with no stability guarantee, so `OSCompat.h` now includes `<react/cxxstableapi/PrivateGuard.h>`, making it a hard error to include from outside React Native's own build under `RN_STRICT_API`. The guard is inert without that macro, so nothing changes for existing consumers. Buck, CMake and podspec wiring is added for the new dependency. That surfaced a leak: `jsinspector-modern/tracing/TraceRecordingState.h` included `<oscompat/OSCompat.h>` without using it, exposing the now-private header through `HostTarget.h`, `InstanceTarget.h`, `RuntimeTarget.h`, `RuntimeAgent.h` and `HostTargetTraceRecording.h`. The unused include is removed, `NetworkReporterTest.cpp` relied on that transitive path and now includes the header directly, and `oscompat` moves to `deps` on the tracing target to match. Changelog: [Internal] Differential Revision: D116012538
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116012538. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
oscompatis an implementation detail with no stability guarantee, soOSCompat.hnow includes<react/cxxstableapi/PrivateGuard.h>, making it a hard error to include from outside React Native's own build underRN_STRICT_API. The guard is inert without that macro, so nothing changes for existing consumers. Buck, CMake and podspec wiring is added for the new dependency.That surfaced a leak:
jsinspector-modern/tracing/TraceRecordingState.hincluded<oscompat/OSCompat.h>without using it, exposing the now-private header throughHostTarget.h,InstanceTarget.h,RuntimeTarget.h,RuntimeAgent.handHostTargetTraceRecording.h. The unused include is removed,NetworkReporterTest.cpprelied on that transitive path and now includes the header directly, andoscompatmoves todepson the tracing target to match.Changelog: [Internal]
Differential Revision: D116012538