Skip to content

Bump main to 10.0-preview#1128

Open
dwcullop wants to merge 2 commits into
reactivemarbles:mainfrom
dwcullop:chore/bump-main-v10-preview
Open

Bump main to 10.0-preview#1128
dwcullop wants to merge 2 commits into
reactivemarbles:mainfrom
dwcullop:chore/bump-main-v10-preview

Conversation

@dwcullop

@dwcullop dwcullop commented Jul 2, 2026

Copy link
Copy Markdown
Member

What

Bump main to 10.0-preview.{height} so preview builds off main publish as v10 preview instead of v9.5 preview.

Also fixes a latent bug in pr-version-check.yml: the major-bump gate looked for a breaking-change (hyphen) label that does not exist in this repo. The real label is breaking change (space). The check and its messages now match the actual label, so this labeled major bump passes.

Why manual

version.json is normally owned by the automation workflows (cut-major, promote-minor, bump-major-preview). The sanctioned way to advance the major is the Bump main to next major preview workflow. This PR is a one-time manual cutover, so it carries the manual-version-edit override label and the breaking change label per the version-check policy.

Verification

  • nbgv get-version computes 10.0.0-preview from the edited version.json.
  • The two label edits in pr-version-check.yml are string-only; no logic change.

dwcullop added 2 commits July 2, 2026 07:32
Cut main over to the next major preview so packages built from main are versioned 10.0.0-preview.{height} instead of 9.5-preview.{height}.

This is a manual version.json edit (the sanctioned override path), so the PR carries the 'manual-version-edit' label; the major bump 9 -> 10 carries 'breaking-change' per pr-version-check.yml.
The workflow gated major bumps on a 'breaking-change' (hyphen) label that
does not exist in the repo; the actual label is 'breaking change' (space).
Align the check and its messages with the real label so a labeled major
bump passes.
@dwcullop dwcullop added breaking change Items that contain a breaking change to the codebase manual-version-edit PR legitimately edits version.json by hand. Bypasses pr-version-check manual-edit guard. labels Jul 2, 2026
@dwcullop dwcullop marked this pull request as ready for review July 2, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Items that contain a breaking change to the codebase manual-version-edit PR legitimately edits version.json by hand. Bypasses pr-version-check manual-edit guard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants