Ignore false-positive cheaper-guard order in DowngradeSubstrFalsyRector - #391
Merged
Conversation
The isName() guard cannot move above the CallLike block, which marks IS_FALSY_UNCASTABLE on arguments of non-substr call nodes; hoisting would skip that side effect and wrongly rewrite nested substr() in falsy-tolerant params. Claude-Session: https://claude.ai/code/session_01Na4eYvNqa2pdhZrBXbegrv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
symplify/phpstan-rules 14.13.0 adds
RectorCheaperGuardsFirstRule, which flags a cheap guard placed after an expensive analysis call.In
DowngradeSubstrFalsyRectortheisName($node, 'substr')guard is flagged, but it cannot be hoisted: the precedingCallLikeblock marksIS_FALSY_UNCASTABLEon the arguments of non-substr call nodes, and that side effect is what lets nestedsubstr()in falsy-tolerant parameter positions be skipped later. Moving the guard up would make non-substr nodes bail before the marking runs, wrongly rewriting those nested calls (covered byskip_as_falsy_argandskip_new_arg_falsyfixtures).Adds a narrow inline
@phpstan-ignorewith the reason. Genuine false positive for this method.