RDDT: rename Go client module to github.com/reddit/milvus/client/v2 - #33
Open
c-i-njoroge wants to merge 1 commit into
Open
RDDT: rename Go client module to github.com/reddit/milvus/client/v2#33c-i-njoroge wants to merge 1 commit into
c-i-njoroge wants to merge 1 commit into
Conversation
Lets consumers require the fork directly, instead of every repo carrying a replace directive that Go only honors in the main module. Co-authored-by: Cursor <cursoragent@cursor.com>
c-i-njoroge
marked this pull request as ready for review
August 13, 2026 03:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets consumers use the internal milvus fork
Closes https://reddit.slack.com/archives/C0ATLKU4PCY/p1786570525956869
💸 TL;DR
Renames this fork's Go client module from
github.com/milvus-io/milvus/client/v2togithub.com/reddit/milvus/client/v2.What is changing
client/go.moddeclares the new module path; therequire/replacepairs in the rootand
tests/go_clientmodules follow it..gofile is themodule path itself — there are no other edits.
.golangci.ymlfiles addgithub.com/redditas a local import prefix. Withoutthis,
gciclassifies the client's own imports as third-party, which fails lint._typos.toml. Thetyposhook only sees files staged in a commit, so on a renamethis wide it renamed exported identifiers in some files but not their declarations in
others, producing code that does not compile. The config documents why each spelling is
intentional :
RaBitQis a real algorithm whose name is the wire value"IVF_RABITQ",WithPartitonsis a deprecated alias whose "fix" collides with the existingWithPartitions, andspeficyappears in server error strings asserted by e2e tests.How it was tested
client: builds, vets, and all 7 test packages pass.tests/go_client: vets clean../client, andinternal/cdc/cluster(the one root-module file touched) builds.
make static-check:client,tests/go_client,and
internal/cdc/clusterall report 0 issues.(
.golangci.ymlsetsbuild-tags: [dynamic, test], pulling in#cgo pkg-config: milvus_core). CI covers it viamake verifiers.📜 Details
Design Doc
Jira
🧪 Testing Steps / Validation
✅ Checks