Skip to content

refac: move profiling queries to proto messages#9663

Draft
AdityaHegde wants to merge 1 commit into
mainfrom
refac/move-to-proto-messages
Draft

refac: move profiling queries to proto messages#9663
AdityaHegde wants to merge 1 commit into
mainfrom
refac/move-to-proto-messages

Conversation

@AdityaHegde

Copy link
Copy Markdown
Collaborator

We moved to using connectrpc but kept the old orval types for reqesut/response. This PR migrated just the profiling queries to directly use proto messages instead of using fromJSON and toJSON

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@nishantmonu51 nishantmonu51 added Type:Improvement Size:XL Very large change: 2,000+ lines labels Jul 10, 2026
@nishantmonu51

Copy link
Copy Markdown
Collaborator

@AdityaHegde : Dow e also expect any performance improvements from this change ?

@AdityaHegde

Copy link
Copy Markdown
Collaborator Author

@nishantmonu51 Not too much, we are converting json <=> proto for all these APIs, so that is the only advantage. The big advantage is types are not needed and we can use proto messages directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size:XL Very large change: 2,000+ lines Type:Improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants