Repository navigation
Add unit tests for request-router service #1275
Description
Overview
src/common/request-router.service.ts has no accompanying *.spec.ts, so its behaviour is unverified and easy to regress. Add focused unit tests covering the service's public methods, including the main success paths and the error/edge cases.
Specifications
Features:
- The service has unit tests covering its public API.
- Both happy-path and failure/edge-case behaviour is asserted.
Tasks:
- Create
src/common/request-router.service.spec.tswith a NestJSTest.createTestingModulesetup and mocked dependencies. - Cover each public method: expected result on success, and error handling on invalid input / dependency failure.
- Ensure the new tests run and pass under the existing Jest config.
Impacted Files:
- src/common/request-router.service.ts
- src/common/request-router.service.spec.ts
Acceptance Criteria
- Every public method of the service has at least one test.
- Success and failure/edge-case paths are both asserted.
- The suite passes in CI.
Activity
sudo-robi commentedon Aug 27, 2026
@sudo-robi has applied to work on this issue as part of the Stellar Wave Program's 8th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @sudo-robi to this issue.
ykargeee-bit commentedon Aug 27, 2026
@ykargeee-bit has applied to work on this issue as part of the Stellar Wave Program's 8th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @ykargeee-bit to this issue.
drips-wave commentedon Aug 27, 2026
Congratulations, @ykargeee-bit! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.
🧑💻 @ykargeee-bit: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.
Warning
When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.
🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.
🌊 Happy Wave 🌊
grantfox-oss commentedon Aug 28, 2026
🎉 This issue has been marked as completed on GrantFox as part of the Third Campaign campaign!
@ykargeee-bit's PR #1362 was approved and merged by @RUKAYAT-CODER.
🏆 @ykargeee-bit: You earned 40 FoxPoints for this contribution! Your current tier: Builder (1,265 total points). Track your full progress on GrantFox.
👏 Great work, @ykargeee-bit! Keep contributing to rinafcode.
drips-wave commentedon Aug 28, 2026
This issue has been completed by @ykargeee-bit as part of the Stellar Wave Program's 8th Wave 🥳
😎 @ykargeee-bit: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.
🧑💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.