Add unit tests for audit-export, mfa, sensitive-operations, adaptive-ttl services - #1359
Merged
Merged
Conversation
…ptive-ttl services Closes rinafcode#1265, rinafcode#1268, rinafcode#1267, rinafcode#1269 — four previously-untested services each get a focused *.spec.ts covering every public method's success and failure/edge-case paths: - AuditExportService: exportToJson/exportToCsv (pretty-printed JSON, header + row shape, missing-optional-field fallback to '', CSV escaping of commas/quotes/newlines, empty-result and query-failure cases). - MfaService: generateTotpSecret (encrypts the secret, hashes recovery codes, saves, returns the QR code + plaintext codes), verifySetup (missing-setup and invalid-code rejections), verifyCode (TOTP path, recovery-code fallback + consumption, no-match path), disableMfa (valid/invalid code). - SensitiveOperationsService: logSensitiveOperation (category resolution incl. unmapped-action fallback, error propagation) plus each of the eight domain-specific wrappers (user deletion, role change, password change, config change, data export, backup create/restore, permission denied, suspicious activity), including the anonymous-actor (null userId/userEmail) paths. - AdaptiveTTLService: getAdaptiveTTL (no match, disabled rule, no metrics clamping, increase/decrease paths, corrupt-rule-data fallback), getRecentAdjustments/getAdjustmentStats (parsing + skipping corrupt records, empty-range average), getRules/updateRules/ updateRule/removeRule/toggleRule (add vs. replace, no-op when no match), cleanupOldAdjustments, and the cache.performance.analyzed event handler. Verified: `npx jest` on all four specs (59 passed), `npm run typecheck` (tsconfig.build.json) and `eslint` are clean.
|
@BigBen-7 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes four issues, each asking for unit test coverage on a previously-untested service:
AuditExportService:exportToJson/exportToCsv(pretty-printed JSON, header + row shape, missing-optional-field fallback to'', CSV escaping of commas/quotes/newlines, empty-result and query-failure cases).MfaService:generateTotpSecret(encrypts the secret, hashes recovery codes, saves, returns the QR code + plaintext codes),verifySetup(missing-setup and invalid-code rejections),verifyCode(TOTP path, recovery-code fallback + consumption, no-match path),disableMfa(valid/invalid code).SensitiveOperationsService:logSensitiveOperation(category resolution incl. unmapped-action fallback, error propagation) plus each of the eight domain-specific wrappers (user deletion, role change, password change, config change, data export, backup create/restore, permission denied, suspicious activity), including the anonymous-actor (nulluserId/userEmail) paths.AdaptiveTTLService:getAdaptiveTTL(no match, disabled rule, no-metrics clamping, increase/decrease paths, corrupt-rule-data fallback),getRecentAdjustments/getAdjustmentStats(parsing + skipping corrupt records, empty-range average),getRules/updateRules/updateRule/removeRule/toggleRule(add vs. replace, no-op when nothing matches),cleanupOldAdjustments, and thecache.performance.analyzedevent handler.No production code was touched — this is test-only, per each issue's scope.
Test plan
npx jeston all four new spec files — 59 passed, 0 failednpm run typecheck(tsconfig.build.json) — cleaneslinton the new files — clean