test+feat: unit tests for audit-log/reporting/grading services + notification-preferences indexes - #1360
Merged
RUKAYAT-CODER merged 1 commit intoAug 27, 2026
Conversation
…vices; add notification-preferences indexes (rinafcode#1264, rinafcode#1266, rinafcode#1261, rinafcode#1248)
|
@bobaivigitalpoint-ui Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves four assigned issues in a single PR.
Changes
src/audit-log/audit-log.service.spec.ts: unit tests covering all public methods of theAuditLogServicefacade (log, logAuth, logDataChange, logApiAccess, logSecurityEvent, search, findAll, findByUser, findByAction, findByEntity, findByIpAddress, findByDateRange, generateReport, getStatistics, applyRetentionPolicy, exportToJson, exportToCsv)src/audit-log/services/audit-reporting.service.spec.ts: unit tests forAuditReportingServicecoveringgenerateReport(zero totals, aggregations, top-users mapping, Unknown email fallback) andgetStatistics(parallel counts, correct severity filters)src/assessment/grading/grading.service.spec.ts: unit tests forGradingServicecoveringgradeSubmission(score mismatch, unknown criterion, duplicate criterion, missing level/points, point capping, levelId resolution, missing attempt) andautoGradeSubmission(not enabled, missing default level, happy path) andfindByAttempt(found, not found)@Indexdecorators added tonotification-preferences.entity.ts(userId,globalUnsubscribe) plus migration1800000000000-add-notification-preferences-indexes.tsto create the indexes on existing databasesCI
Closes #1264
Closes #1266
Closes #1261
Closes #1248